From 8f3b1e2132f031bb09eaeb7eff9792ceec890e7b Mon Sep 17 00:00:00 2001 From: RevLayDust <225862333+RevLayDust@users.noreply.github.com> Date: Mon, 21 Sep 2026 22:20:50 +0700 Subject: [PATCH] fix(installer): prevent onnxruntime package collision and track output directory - Ensure onnxruntime CPU and GPU packages do not collide by cleanly uninstalling conflicting variant before installation - Update APP_NAME branding to 'RLD UVR-Opt' and clarify OS compatibility warnings in install_packages.bat - Remove obsolete root-level install_packages.sh script and ignore install/install_packages.sh in .gitignore - Add placeholder text file to preserve output/ directory tracking in git --- .gitignore | 5 ++++- install/install_packages.bat | 6 ++++-- install_packages.sh | 5 ----- output/this is output folder.txt | 0 4 files changed, 8 insertions(+), 8 deletions(-) delete mode 100644 install_packages.sh create mode 100644 output/this is output folder.txt diff --git a/.gitignore b/.gitignore index ee42c9e..f204477 100644 --- a/.gitignore +++ b/.gitignore @@ -13,10 +13,13 @@ venv/ benchmark_cache/ output/* +!output/*.txt uvr_run.log data.pkl error.log CONTRIBUTING.md rubberband.exe -ffmpeg.exe \ No newline at end of file +ffmpeg.exe + +install/install_packages.sh \ No newline at end of file diff --git a/install/install_packages.bat b/install/install_packages.bat index a358686..81b7b8a 100644 --- a/install/install_packages.bat +++ b/install/install_packages.bat @@ -14,7 +14,7 @@ if errorlevel 1 ( ) set "INSTALLER_FILE=" -set "APP_NAME=Ultimate Vocal Remover" +set "APP_NAME=RLD UVR-Opt" set "PYTHON_VERSION=3.11.9" set "VENV_DIR=..\venv" set "VENV_PYTHON=%VENV_DIR%\Scripts\python.exe" @@ -89,7 +89,7 @@ exit /b 0 :check_windows if /i not "%OS%"=="Windows_NT" ( - call :warn "This installer is designed for Windows. Use install_packages.sh on other operating systems." + call :warn "This installer is designed for Windows. Not compatible with Linux and Mac OS for now." ) exit /b 0 @@ -334,6 +334,7 @@ if errorlevel 1 ( ) echo Installing ONNX Runtime GPU compatibility package... +uv pip uninstall --python "%VENV_PYTHON%" -y onnxruntime >nul 2>&1 uv pip install --python "%VENV_PYTHON%" onnxruntime-gpu==1.22.0 if errorlevel 1 call :warn "Failed to install onnxruntime-gpu. UVR can still use PyTorch CUDA, but ONNX models may fall back or fail." exit /b 0 @@ -348,6 +349,7 @@ if errorlevel 1 ( exit /b 1 ) +uv pip uninstall --python "%VENV_PYTHON%" -y onnxruntime-gpu >nul 2>&1 uv pip install --python "%VENV_PYTHON%" onnxruntime==1.22.0 if errorlevel 1 call :warn "Failed to install ONNX Runtime CPU. PyTorch models can still run, but ONNX models may fail." exit /b 0 diff --git a/install_packages.sh b/install_packages.sh deleted file mode 100644 index 6419399..0000000 --- a/install_packages.sh +++ /dev/null @@ -1,5 +0,0 @@ -#!/bin/bash - -while read package; do - pip install "$package" -done < requirements.txt diff --git a/output/this is output folder.txt b/output/this is output folder.txt new file mode 100644 index 0000000..e69de29