diff --git a/src/UltraSinger.py b/src/UltraSinger.py index 1bce5b7..2b52d0c 100644 --- a/src/UltraSinger.py +++ b/src/UltraSinger.py @@ -710,7 +710,7 @@ def pitch_audio( pitched_data_path = os.path.join(process_data_paths.cache_folder_path, f"{pitching_config}.json") cache_available = check_file_exists(pitched_data_path) - if settings.skip_cache_transcription or not cache_available: + if settings.skip_cache_pitch_detection or not cache_available: pitched_data = get_pitch_with_file( process_data_paths.processing_audio_path ) diff --git a/src/modules/Ultrastar/coverter/ultrastar_txt_converter.py b/src/modules/Ultrastar/coverter/ultrastar_txt_converter.py index 00127cf..fc9993b 100644 --- a/src/modules/Ultrastar/coverter/ultrastar_txt_converter.py +++ b/src/modules/Ultrastar/coverter/ultrastar_txt_converter.py @@ -66,6 +66,8 @@ def create_ultrastar_txt_from_automation( ultrastar_txt = UltrastarTxtValue() ultrastar_txt.version = format_version.value + if media_info.audio_extension is None: + raise Exception("Missing Audio extension. It is required to create Ultrastar txt") ultrastar_txt.mp3 = basename + "." + media_info.audio_extension ultrastar_txt.audio = basename + "." + media_info.audio_extension ultrastar_txt.vocals = basename + " [Vocals]." + media_info.audio_extension diff --git a/src/modules/Ultrastar/ultrastar_writer.py b/src/modules/Ultrastar/ultrastar_writer.py index 936e752..1ef5d1e 100644 --- a/src/modules/Ultrastar/ultrastar_writer.py +++ b/src/modules/Ultrastar/ultrastar_writer.py @@ -53,7 +53,7 @@ def create_ultrastar_txt( gap = midi_segments[0].start if version.parse(ultrastar_class.version) >= version.parse("1.0.0"): - file.write(f"#{UltrastarTxtTag.VERSION.value}:{ultrastar_class.version}\n"), + file.write(f"#{UltrastarTxtTag.VERSION.value}:{ultrastar_class.version}\n") file.write(f"#{UltrastarTxtTag.ARTIST.value}:{ultrastar_class.artist}\n") file.write(f"#{UltrastarTxtTag.TITLE.value}:{ultrastar_class.title}\n") if ultrastar_class.year is not None: