diff --git a/frontend/app/admin/jobs/page.tsx b/frontend/app/admin/jobs/page.tsx index d67dd30a..f52d87b1 100644 --- a/frontend/app/admin/jobs/page.tsx +++ b/frontend/app/admin/jobs/page.tsx @@ -1035,8 +1035,8 @@ function AdminJobsPageContent() {

{[ { key: "theme_id", label: "Theme", value: selectedJob.theme_id || "default" }, - { key: "brand_prefix", label: "Brand Prefix", value: (selectedJob as any).brand_prefix }, - { key: "customer_email", label: "Customer Email", value: (selectedJob as any).customer_email }, + { key: "brand_prefix", label: "Brand Prefix", value: selectedJob.brand_prefix }, + { key: "customer_email", label: "Customer Email", value: selectedJob.customer_email }, ].map(({ key, label, value }) => (
{label}: diff --git a/frontend/app/admin/rate-limits/__tests__/page.test.tsx b/frontend/app/admin/rate-limits/__tests__/page.test.tsx index a65b0cbc..b279b8ef 100644 --- a/frontend/app/admin/rate-limits/__tests__/page.test.tsx +++ b/frontend/app/admin/rate-limits/__tests__/page.test.tsx @@ -69,7 +69,7 @@ const mockOverrides = { { email: "vip@example.com", bypass_job_limit: true, - custom_daily_job_limit: null, + custom_daily_job_limit: undefined, reason: "VIP user", created_by: "admin@nomadkaraoke.com", created_at: "2025-01-08T15:00:00Z", @@ -242,7 +242,7 @@ describe("AdminRateLimitsPage", () => { }) it("adds a disposable domain", async () => { - mockAdminApi.addDisposableDomain.mockResolvedValue({ success: true }) + mockAdminApi.addDisposableDomain.mockResolvedValue({ success: true, message: "Operation successful" }) const user = userEvent.setup() render() @@ -339,7 +339,7 @@ describe("AdminRateLimitsPage", () => { }) it("creates a new override", async () => { - mockAdminApi.setUserOverride.mockResolvedValue({ success: true }) + mockAdminApi.setUserOverride.mockResolvedValue({ success: true, message: "Operation successful" }) const user = userEvent.setup() render() diff --git a/frontend/components/__tests__/AuthStatus.test.tsx b/frontend/components/__tests__/AuthStatus.test.tsx index ae76755e..9ed0408b 100644 --- a/frontend/components/__tests__/AuthStatus.test.tsx +++ b/frontend/components/__tests__/AuthStatus.test.tsx @@ -12,7 +12,7 @@ jest.mock('@/lib/auth', () => ({ useAuth: jest.fn(), })) -const mockUseAuth = useAuth as jest.Mock +const mockUseAuth = useAuth as unknown as jest.Mock // Mock window.location.reload const mockReload = jest.fn() diff --git a/frontend/components/__tests__/JobCard.test.tsx b/frontend/components/__tests__/JobCard.test.tsx index ffa341f7..2e3dcb98 100644 --- a/frontend/components/__tests__/JobCard.test.tsx +++ b/frontend/components/__tests__/JobCard.test.tsx @@ -100,7 +100,7 @@ describe('JobCard', () => { expect(reviewLink).toBeInTheDocument() const href = reviewLink.closest('a')?.getAttribute('href') || '' // Uses hash-based routing for static hosting - // Note: Next.js Link normalizes the URL, removing trailing slash before hash + // Uses tag (not Next.js Link) to ensure hashchange event fires expect(href).toBe('/app/jobs#/123/review') }) @@ -123,7 +123,7 @@ describe('JobCard', () => { expect(instrumentalLink).toBeInTheDocument() const href = instrumentalLink.closest('a')?.getAttribute('href') || '' // Uses hash-based routing for static hosting - // Note: Next.js Link normalizes the URL, removing trailing slash before hash + // Uses tag (not Next.js Link) to ensure hashchange event fires expect(href).toBe('/app/jobs#/123/instrumental') }) diff --git a/frontend/components/admin/stats-card.tsx b/frontend/components/admin/stats-card.tsx index 7ee26383..a42646a3 100644 --- a/frontend/components/admin/stats-card.tsx +++ b/frontend/components/admin/stats-card.tsx @@ -17,6 +17,7 @@ interface StatsCardProps { } loading?: boolean className?: string + valueClassName?: string } export function StatsCard({ @@ -27,6 +28,7 @@ export function StatsCard({ trend, loading, className, + valueClassName, }: StatsCardProps) { if (loading) { return ( @@ -53,7 +55,7 @@ export function StatsCard({ {Icon && } -
{value}
+
{value}
{description && (

{description}

)} @@ -73,12 +75,20 @@ export function StatsCard({ interface StatsGridProps { children: React.ReactNode className?: string + columns?: 2 | 3 | 4 } -export function StatsGrid({ children, className }: StatsGridProps) { +export function StatsGrid({ children, className, columns }: StatsGridProps) { + const colsClass = columns === 2 + ? "md:grid-cols-2" + : columns === 3 + ? "md:grid-cols-2 lg:grid-cols-3" + : "md:grid-cols-2 lg:grid-cols-4" + return (
{children} diff --git a/frontend/components/job/JobCard.tsx b/frontend/components/job/JobCard.tsx index 7fbbe6ab..b031c9ff 100644 --- a/frontend/components/job/JobCard.tsx +++ b/frontend/components/job/JobCard.tsx @@ -1,7 +1,6 @@ "use client" import { useState } from "react" -import Link from "next/link" import { Job } from "@/lib/api" import { Button } from "@/components/ui/button" import { Zap } from "lucide-react" @@ -102,13 +101,14 @@ export function JobCard({ job, onRefresh }: JobCardProps) { } if (job.status === "awaiting_review" || job.status === "in_review") { + // Use instead of Link for hash-based URLs to ensure hashchange event fires return ( - Review Lyrics - + ) } @@ -125,13 +125,14 @@ export function JobCard({ job, onRefresh }: JobCardProps) { } if (job.status === "awaiting_instrumental_selection") { + // Use instead of Link for hash-based URLs to ensure hashchange event fires return ( - Select Instrumental - + ) } diff --git a/frontend/components/ui/dialog.tsx b/frontend/components/ui/dialog.tsx index c8fa3bb9..ae527968 100644 --- a/frontend/components/ui/dialog.tsx +++ b/frontend/components/ui/dialog.tsx @@ -25,10 +25,14 @@ const DialogOverlay = React.forwardRef< )) DialogOverlay.displayName = DialogPrimitive.Overlay.displayName +interface DialogContentProps extends React.ComponentPropsWithoutRef { + showCloseButton?: boolean +} + const DialogContent = React.forwardRef< React.ElementRef, - React.ComponentPropsWithoutRef ->(({ className, children, ...props }, ref) => ( + DialogContentProps +>(({ className, children, showCloseButton = true, ...props }, ref) => ( {children} - - - Close - + {showCloseButton && ( + + + Close + + )} )) diff --git a/frontend/e2e/production/test-existing-job.spec.ts b/frontend/e2e/production/test-existing-job.spec.ts index a3a94f5d..3fc7cf08 100644 --- a/frontend/e2e/production/test-existing-job.spec.ts +++ b/frontend/e2e/production/test-existing-job.spec.ts @@ -243,7 +243,7 @@ async function testLyricsReview(page: any, context: any, jobId: string) { console.log(` WARNING: Preview error: ${errorText}`); } else if (await videoElement.isVisible({ timeout: 10000 }).catch(() => false)) { console.log(' Video element visible'); - const videoState = await videoElement.first().evaluate((el) => { + const videoState = await videoElement.first().evaluate((el: Element) => { const video = el as HTMLVideoElement; return { src: video.src?.substring(0, 50), diff --git a/frontend/jest.setup.d.ts b/frontend/jest.setup.d.ts new file mode 100644 index 00000000..e48dee96 --- /dev/null +++ b/frontend/jest.setup.d.ts @@ -0,0 +1 @@ +/// diff --git a/frontend/lib/api.ts b/frontend/lib/api.ts index 1c880429..9c1c0abd 100644 --- a/frontend/lib/api.ts +++ b/frontend/lib/api.ts @@ -55,6 +55,7 @@ export interface Job { title?: string; filename?: string; error_message?: string; + error_details?: Record; file_urls?: Record; state_data?: Record; timeline?: Array<{ @@ -70,6 +71,16 @@ export interface Job { user_email?: string; outputs_deleted_at?: string; outputs_deleted_by?: string; + // Audio search fields + audio_search_artist?: string; + audio_search_title?: string; + // Theme and branding + theme_id?: string; + brand_prefix?: string; + // Customer order fields + customer_email?: string; + // Request tracking metadata + request_metadata?: Record; } export interface UploadJobResponse {