From f50efed4ef321b4164bf20530ea16dd40c2ac0d4 Mon Sep 17 00:00:00 2001 From: Andrew Beveridge Date: Thu, 19 Nov 2026 13:31:47 -0500 Subject: [PATCH] feat(iam): claude-readonly may read all secret values (Andrew's call) Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_012RYLVVVVLQSWvtZqBGxRFb --- CLAUDE.md | 2 +- .../modules/iam/claude_readonly_sa.py | 18 +++++------------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index 8db0c236..2e9d7955 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -68,7 +68,7 @@ This single command: When asked to "test it yourself in prod" or verify a fix in production: ```bash -# Get admin token. claude-readonly@ may read this one secret (Pulumi: +# Get admin token. claude-readonly@ can read all secrets (Pulumi: # infrastructure/modules/iam/claude_readonly_sa.py), so no gcloud login is needed. export KARAOKE_ADMIN_TOKEN=$(gcloud secrets versions access latest --secret=admin-tokens --project=nomadkaraoke --account=claude-readonly@nomadkaraoke.iam.gserviceaccount.com | cut -d',' -f1) diff --git a/infrastructure/modules/iam/claude_readonly_sa.py b/infrastructure/modules/iam/claude_readonly_sa.py index 94101466..363d60dc 100644 --- a/infrastructure/modules/iam/claude_readonly_sa.py +++ b/infrastructure/modules/iam/claude_readonly_sa.py @@ -44,6 +44,11 @@ def grant_claude_readonly_permissions( "bigquery_job_user": "roles/bigquery.jobUser", "storage_viewer": "roles/storage.objectViewer", "secretmanager_viewer": "roles/secretmanager.viewer", + # Secret VALUES too (Andrew, 2026-11-19): sessions need the admin API + # token, OAuth creds etc. for remediation, and the gcloud CLI user login + # keeps lapsing. This makes the SA's key secret-equivalent: anyone with + # it can read every secret in the project. + "secretmanager_accessor": "roles/secretmanager.secretAccessor", "run_viewer": "roles/run.viewer", "compute_viewer": "roles/compute.viewer", "logging_viewer": "roles/logging.viewer", @@ -59,19 +64,6 @@ def grant_claude_readonly_permissions( ), ) - # The one secret sessions may read: the backend admin API token. Sessions - # need it to retry/inspect jobs via the API (CLAUDE.md "API Authentication"), - # and the gcloud CLI's user login lapses, so without this every session hit - # a wall. Andrew asked for it on 2026-11-19. Deliberately scoped to this one - # secret; all other secret values stay unreadable to claude-readonly. - bindings["admin_tokens_accessor"] = gcp.secretmanager.SecretIamMember( - "claude-readonly-admin-tokens-access", - project=PROJECT_ID, - secret_id="admin-tokens", - role="roles/secretmanager.secretAccessor", - member=service_account.email.apply(lambda email: f"serviceAccount:{email}"), - ) - return bindings