From f997cd7de2b2ae1e3279309a27461f23cb4e602a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrew=20Beveridge=20=E2=98=84=EF=B8=8F?= Date: Thu, 17 Sep 2026 19:36:27 -0400 Subject: [PATCH] =?UTF-8?q?docs:=20session=20record=20=E2=80=94=20review?= =?UTF-8?q?=20fast-full-load=20(#1018)=20+=20E2E=20canary=20regression=20f?= =?UTF-8?q?ix=20(#1022)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Session record for 2026-09-17: the review fast-full-load re-architecture (#1018, v0.229.0) and the diagnosis/verification of the post-deploy canary regression (#1019 → fixed by #1020). Docs-only. Co-authored-by: Claude Opus 4.8 --- ...-17-review-fast-load-and-e2e-canary-fix.md | 60 +++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 docs/sessions/2026-Q3/2026-09-17-review-fast-load-and-e2e-canary-fix.md diff --git a/docs/sessions/2026-Q3/2026-09-17-review-fast-load-and-e2e-canary-fix.md b/docs/sessions/2026-Q3/2026-09-17-review-fast-load-and-e2e-canary-fix.md new file mode 100644 index 00000000..459b68bb --- /dev/null +++ b/docs/sessions/2026-Q3/2026-09-17-review-fast-load-and-e2e-canary-fix.md @@ -0,0 +1,60 @@ +# Review fast-full-load + E2E canary regression fix — 2026-09-17 + +**Project:** karaoke-gen **Branch/commit:** main @ `303ff7e7` **Status:** done (shipped + deployed + canary-verified) + +## Summary + +Two pieces of work, back to back: + +1. **Review page fast-full-load re-architecture (PR #1018, v0.229.0).** Picked up from a prior-session handoff. Root-cause fix for the 2026-09-17 signing-hang incident: removed the IAM `signBlob` network round-trip from the `/api/review/{id}/correction-data` hot path entirely, so the review page always loads fast with audio present on first paint (not the degraded fail-soft path v0.228.1 fell back to). + +2. **Post-deploy canary regression diagnosis + verification.** v0.229.0's post-deploy canary went red. Diagnosed it as a regression from **#1019** (not #1018): the happy-path canary's admin `e2e-test-runner` account got added to the test-email allowlist, and `exclude_test` then hid its own just-created job from its own list → STEP 5 "job card visible" timed out. Andrew had already shipped the identical fix (#1020) in parallel; my duplicate (#1021) was closed. Watched the deploy through and confirmed **both** the deploy canary and the daily E2E happy-path are green again. + +## What changed + +### PR #1018 — review fast-full-load (Option B: same-origin byte proxy), v0.229.0 +- **`backend/api/routes/review.py`:** + - New endpoint `GET /{job_id}/instrumental-audio/{option_id}` — streams the transcoded OGG bytes with HTTP Range (206) support, `require_review_auth` (token via query for raw `