mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
Phase 6 (mobile release readiness) — gen side. Spec: nomad-mobile
`docs/superpowers/specs/2026-10-25-mobile-phase6-release-readiness-design.md`
(§4 payments, §5 push, §6 deletion, §9 demo account).
## What
- **`/me` app fields:** opaque `app_user_id` (UUID, used for
RevenueCat/Sentry — no email to third parties),
`capabilities.account_deletion`, `push_prefs`.
- **In-app purchases:** `POST /api/users/webhooks/revenuecat` (shared
Authorization header). Exactly-once grants keyed by
`{store}:{transaction_id}` inside the same Firestore transaction as the
balance change; refunds (REFUND / CANCELLATION with CUSTOMER_SUPPORT or
negative price) debit the granted account, refund tombstones block late
grants; other cancellations ignored. `store_payments` for accounting +
revenue sums; referral earnings on **net** proceeds; sandbox grants but
excluded from revenue/referrals. Credit packages gain `store_product_id`
+ server-driven `web_link` (iOS US only for now).
- **Push:** `POST/DELETE /api/push/expo-token` (token moves between
users atomically), `PATCH /api/users/me/push-prefs` (ready / review /
problems, gates Expo **and** Web Push), Expo sender (batched,
DeviceNotRegistered cleanup), new FAILED / AWAITING_AUDIO_SELECTION
triggers.
- **Account deletion** (`ACCOUNT_DELETION_ENABLED`, **off in prod**
until Andrew's manual pass): `GET /api/users/me/deletion-preview`,
`DELETE /api/users/me`. Refuses admin / unpaid referral balance / Stripe
Connect / made-for-you in progress (409). Cancels active jobs, deletes
decide data (partner call, twice), RevenueCat subscriber, revokes Sign
in with Apple (when a code is given), queues kjbox
(`/api/kjbox/account-deletions` pull + ack), deletes **inputs only**
(uploads, input/, audio_edit/, style/, staged instrumentals) — **never
published outputs** — strips personal fields, anonymises
jobs/referrals/song requests/show-credit records, keeps payment records.
Every step idempotent; failures → 503 retry; sessions revoked last.
- **Web:** `/account/delete` page (Google Play web deletion path),
hidden while the flag is off.
- **App Review demo login:** fixed code for one configured email — inert
until `APP_REVIEW_DEMO_EMAIL` is set (not set in prod).
- **CI:** mounts `REVENUECAT_WEBHOOK_AUTH`, `REVENUECAT_SECRET_API_KEY`,
`APP_REVIEW_DEMO_CODE` (secrets exist; runtime SA already has accessor).
## Tests
6838 backend unit tests pass (emulator suite needs emulators;
iap/deletion emulator tests pass locally), frontend jest 1785/1785.
Per-task reviews + local CodeRabbit review (5 minor findings fixed).
@coderabbitai ignore
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01CZf1cM9vefnNw5djARRhyA
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
61 lines
2.5 KiB
Python
61 lines
2.5 KiB
Python
"""gen → karaoke-decide partner calls (``X-Partner-Secret``).
|
|
|
|
decide already authenticates to gen with ``DECIDE_GEN_PARTNER_SECRET``; account
|
|
deletion uses the same secret in the other direction to erase a gen user's
|
|
decide data. The host is gen's existing decide setting
|
|
(``karaoke_decide_api_url``, default https://decide.nomadkaraoke.com), which is
|
|
decide's main API (the catalog proxy uses the same host).
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
from typing import Optional
|
|
|
|
import httpx
|
|
|
|
from backend.config import get_settings
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
_TIMEOUT_SECONDS = 30
|
|
USERS_PATH = "/api/partner/gen/users"
|
|
|
|
|
|
class DecidePartnerError(RuntimeError):
|
|
"""decide is unconfigured or answered non-2xx."""
|
|
|
|
|
|
class DecidePartnerClient:
|
|
def __init__(self, base_url: Optional[str] = None, secret: Optional[str] = None, http_client=None):
|
|
settings = get_settings()
|
|
self.base_url = (base_url if base_url is not None else settings.karaoke_decide_api_url or "").rstrip("/")
|
|
self.secret = secret if secret is not None else settings.decide_partner_secret
|
|
self._http_client = http_client # injectable httpx.Client for tests
|
|
|
|
def delete_user(self, email: str) -> dict:
|
|
"""Erase every decide store for the gen user ``email``. Idempotent on decide's side.
|
|
|
|
Returns decide's ``{"deleted": {collection: count}}``. Raises
|
|
:class:`DecidePartnerError` when unconfigured or on any non-2xx.
|
|
"""
|
|
if not self.base_url or not self.secret:
|
|
raise DecidePartnerError("decide partner API not configured (karaoke_decide_api_url / DECIDE_GEN_PARTNER_SECRET)")
|
|
url = f"{self.base_url}{USERS_PATH}"
|
|
headers = {"X-Partner-Secret": self.secret}
|
|
body = {"email": email.strip().lower()}
|
|
try:
|
|
if self._http_client is not None:
|
|
resp = self._http_client.request("DELETE", url, json=body, headers=headers)
|
|
else:
|
|
with httpx.Client(timeout=_TIMEOUT_SECONDS) as client:
|
|
resp = client.request("DELETE", url, json=body, headers=headers)
|
|
except httpx.HTTPError as e:
|
|
raise DecidePartnerError(f"decide delete request failed: {type(e).__name__}") from e
|
|
if not 200 <= resp.status_code < 300:
|
|
raise DecidePartnerError(f"decide delete returned HTTP {resp.status_code}")
|
|
try:
|
|
data = resp.json()
|
|
except ValueError:
|
|
data = {}
|
|
return data if isinstance(data, dict) else {}
|