mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary Theme 7 of the silent-fallback audit (`docs/archive/2026-06-09-fallback-audit-plan.md`, in #805). A single unset/rotated env var used to silently produce wrong behaviour in prod with only a warning. Now production fails fast / is safe-by-default. Verified against Pulumi infra: prod sets `ENVIRONMENT=production`, `CLOUD_RUN_SERVICE_URL`, `GCS_BUCKET_NAME`, `GOOGLE_CLOUD_PROJECT`, and Postmark (secret); Cloud Run also auto-sets `K_SERVICE`. ## Changes - **`config.is_production()` + `validate_production_config()`** (called from `main.py` lifespan): production refuses to boot if `GOOGLE_CLOUD_PROJECT`, `GCS_BUCKET_NAME`, or `CLOUD_RUN_SERVICE_URL` are unset — instead of silently using a dev default (wrong project for secret lookups / wrong bucket / localhost worker URL). This **subsumes 7.3** (worker_service localhost fallback). `is_production()` treats Cloud Run's auto-set `K_SERVICE` as production, so it's robust even if `ENVIRONMENT` were unset. - **Tenant middleware (7.4, security)**: the `?tenant=` override (a spoofing vector) is now disabled whenever `K_SERVICE` is present, not only when `ENVIRONMENT=production` — production-safe by default. - **dropbox_service (7.1)**: `GOOGLE_CLOUD_PROJECT` default was the **wrong literal** `"karaoke-gen"` (real project is `nomadkaraoke`); replaced with an empty default (prod requires it via the startup gate). - **email_service (7.5)**: a missing `POSTMARK_SERVER_TOKEN` in production used to silently use the console provider (sends "succeed" while emails vanish). Now raises in production; console fallback remains for dev/test. ## Deferred (flagged) **7.2** `GCS_TEMP_BUCKET` / `GCS_OUTPUT_BUCKET` — these are **not** set via env in infra, so their config defaults are load-bearing. Requiring or changing them risks prod, so deferred pending confirmation of whether those buckets are actually used. ## Testing - [x] New `backend/tests/test_fallback_prod_config.py` (is_production, validate gate raise/pass/no-op, email prod-raise vs dev-console, tenant K_SERVICE) - [x] 111 related tests pass (email, tenant, config) — no regressions, no cross-test pollution from the tenant module reload ## Review - [x] CodeRabbit CLI review completed locally (0 findings) @coderabbitai ignore --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
103 lines
3.9 KiB
Python
103 lines
3.9 KiB
Python
"""
|
|
Fallback audit (Theme 7): production must fail loudly on missing required config
|
|
rather than silently running on dev defaults (wrong GCP project / GCS bucket /
|
|
localhost worker URL / console-only email), and the tenant query-param override
|
|
must be production-safe by default.
|
|
"""
|
|
import importlib
|
|
|
|
import pytest
|
|
|
|
from backend.config import is_production, validate_production_config
|
|
from backend.services.email_service import EmailService
|
|
|
|
|
|
# ---- is_production() ----
|
|
|
|
def test_is_production_via_environment(monkeypatch):
|
|
monkeypatch.setenv("ENVIRONMENT", "production")
|
|
monkeypatch.delenv("K_SERVICE", raising=False)
|
|
assert is_production() is True
|
|
|
|
|
|
def test_is_production_via_k_service(monkeypatch):
|
|
"""Cloud Run sets K_SERVICE automatically — production-safe even if ENVIRONMENT is unset."""
|
|
monkeypatch.delenv("ENVIRONMENT", raising=False)
|
|
monkeypatch.delenv("ENV", raising=False)
|
|
monkeypatch.setenv("K_SERVICE", "karaoke-api")
|
|
assert is_production() is True
|
|
|
|
|
|
def test_is_production_false_in_dev(monkeypatch):
|
|
monkeypatch.delenv("ENVIRONMENT", raising=False)
|
|
monkeypatch.delenv("ENV", raising=False)
|
|
monkeypatch.delenv("K_SERVICE", raising=False)
|
|
assert is_production() is False
|
|
|
|
|
|
# ---- validate_production_config() ----
|
|
|
|
def test_validate_raises_when_required_var_missing_in_prod(monkeypatch):
|
|
monkeypatch.setenv("ENVIRONMENT", "production")
|
|
monkeypatch.delenv("K_SERVICE", raising=False)
|
|
monkeypatch.setenv("GOOGLE_CLOUD_PROJECT", "nomadkaraoke")
|
|
monkeypatch.setenv("GCS_BUCKET_NAME", "karaoke-gen-storage-nomadkaraoke")
|
|
monkeypatch.delenv("CLOUD_RUN_SERVICE_URL", raising=False) # missing!
|
|
|
|
with pytest.raises(RuntimeError, match="CLOUD_RUN_SERVICE_URL"):
|
|
validate_production_config()
|
|
|
|
|
|
def test_validate_passes_when_all_required_set_in_prod(monkeypatch):
|
|
monkeypatch.setenv("ENVIRONMENT", "production")
|
|
monkeypatch.delenv("K_SERVICE", raising=False)
|
|
monkeypatch.setenv("GOOGLE_CLOUD_PROJECT", "nomadkaraoke")
|
|
monkeypatch.setenv("GCS_BUCKET_NAME", "karaoke-gen-storage-nomadkaraoke")
|
|
monkeypatch.setenv("CLOUD_RUN_SERVICE_URL", "https://api.nomadkaraoke.com")
|
|
|
|
validate_production_config() # must not raise
|
|
|
|
|
|
def test_validate_noop_in_dev(monkeypatch):
|
|
monkeypatch.delenv("ENVIRONMENT", raising=False)
|
|
monkeypatch.delenv("ENV", raising=False)
|
|
monkeypatch.delenv("K_SERVICE", raising=False)
|
|
monkeypatch.delenv("CLOUD_RUN_SERVICE_URL", raising=False)
|
|
validate_production_config() # no-op, must not raise
|
|
|
|
|
|
# ---- email provider (7.5) ----
|
|
|
|
def test_email_provider_raises_in_prod_without_postmark(monkeypatch):
|
|
monkeypatch.setenv("ENVIRONMENT", "production")
|
|
monkeypatch.delenv("K_SERVICE", raising=False)
|
|
monkeypatch.delenv("POSTMARK_SERVER_TOKEN", raising=False)
|
|
with pytest.raises(RuntimeError, match="POSTMARK_SERVER_TOKEN"):
|
|
EmailService()
|
|
|
|
|
|
def test_email_provider_console_in_dev_without_postmark(monkeypatch):
|
|
monkeypatch.delenv("ENVIRONMENT", raising=False)
|
|
monkeypatch.delenv("ENV", raising=False)
|
|
monkeypatch.delenv("K_SERVICE", raising=False)
|
|
monkeypatch.delenv("POSTMARK_SERVER_TOKEN", raising=False)
|
|
svc = EmailService() # must not raise — console fallback is fine in dev
|
|
assert svc.is_configured() is False
|
|
|
|
|
|
# ---- tenant gate (7.4) ----
|
|
|
|
def test_tenant_gate_production_safe_with_k_service(monkeypatch):
|
|
"""K_SERVICE present (Cloud Run) → IS_PRODUCTION True → query-param override disabled."""
|
|
monkeypatch.delenv("ENVIRONMENT", raising=False)
|
|
monkeypatch.delenv("ENV", raising=False)
|
|
monkeypatch.setenv("K_SERVICE", "karaoke-api")
|
|
import backend.middleware.tenant as tenant_mod
|
|
try:
|
|
importlib.reload(tenant_mod)
|
|
assert tenant_mod.IS_PRODUCTION is True
|
|
finally:
|
|
# Restore module to a clean (dev) state so other tests aren't affected.
|
|
monkeypatch.delenv("K_SERVICE", raising=False)
|
|
importlib.reload(tenant_mod)
|