mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
Phase 6 (mobile release readiness) — gen side. Spec: nomad-mobile
`docs/superpowers/specs/2026-10-25-mobile-phase6-release-readiness-design.md`
(§4 payments, §5 push, §6 deletion, §9 demo account).
## What
- **`/me` app fields:** opaque `app_user_id` (UUID, used for
RevenueCat/Sentry — no email to third parties),
`capabilities.account_deletion`, `push_prefs`.
- **In-app purchases:** `POST /api/users/webhooks/revenuecat` (shared
Authorization header). Exactly-once grants keyed by
`{store}:{transaction_id}` inside the same Firestore transaction as the
balance change; refunds (REFUND / CANCELLATION with CUSTOMER_SUPPORT or
negative price) debit the granted account, refund tombstones block late
grants; other cancellations ignored. `store_payments` for accounting +
revenue sums; referral earnings on **net** proceeds; sandbox grants but
excluded from revenue/referrals. Credit packages gain `store_product_id`
+ server-driven `web_link` (iOS US only for now).
- **Push:** `POST/DELETE /api/push/expo-token` (token moves between
users atomically), `PATCH /api/users/me/push-prefs` (ready / review /
problems, gates Expo **and** Web Push), Expo sender (batched,
DeviceNotRegistered cleanup), new FAILED / AWAITING_AUDIO_SELECTION
triggers.
- **Account deletion** (`ACCOUNT_DELETION_ENABLED`, **off in prod**
until Andrew's manual pass): `GET /api/users/me/deletion-preview`,
`DELETE /api/users/me`. Refuses admin / unpaid referral balance / Stripe
Connect / made-for-you in progress (409). Cancels active jobs, deletes
decide data (partner call, twice), RevenueCat subscriber, revokes Sign
in with Apple (when a code is given), queues kjbox
(`/api/kjbox/account-deletions` pull + ack), deletes **inputs only**
(uploads, input/, audio_edit/, style/, staged instrumentals) — **never
published outputs** — strips personal fields, anonymises
jobs/referrals/song requests/show-credit records, keeps payment records.
Every step idempotent; failures → 503 retry; sessions revoked last.
- **Web:** `/account/delete` page (Google Play web deletion path),
hidden while the flag is off.
- **App Review demo login:** fixed code for one configured email — inert
until `APP_REVIEW_DEMO_EMAIL` is set (not set in prod).
- **CI:** mounts `REVENUECAT_WEBHOOK_AUTH`, `REVENUECAT_SECRET_API_KEY`,
`APP_REVIEW_DEMO_CODE` (secrets exist; runtime SA already has accessor).
## Tests
6838 backend unit tests pass (emulator suite needs emulators;
iap/deletion emulator tests pass locally), frontend jest 1785/1785.
Per-task reviews + local CodeRabbit review (5 minor findings fixed).
@coderabbitai ignore
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01CZf1cM9vefnNw5djARRhyA
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
132 lines
4.4 KiB
Python
132 lines
4.4 KiB
Python
"""Tests for the mobile-app fields on GET /api/users/me (app_user_id, capabilities, push_prefs)."""
|
|
import sys
|
|
import uuid
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
from fastapi.testclient import TestClient
|
|
|
|
sys.modules.setdefault('google.cloud.firestore', MagicMock())
|
|
sys.modules.setdefault('google.cloud.firestore_v1', MagicMock())
|
|
|
|
from backend.main import app
|
|
from backend.models.user import ExpoPushToken, User
|
|
from backend.services.auth_service import AuthResult, UserType
|
|
from backend.services.user_service import UserService, get_user_service
|
|
|
|
EMAIL = "singer@example.com"
|
|
|
|
|
|
class FakeUserService:
|
|
"""Mints like the real service: once, then returns the stored id."""
|
|
|
|
def __init__(self, user):
|
|
self.user = user
|
|
|
|
def get_or_create_user(self, email, **kwargs):
|
|
return self.user
|
|
|
|
def ensure_app_user_id(self, email):
|
|
if not self.user.app_user_id:
|
|
self.user.app_user_id = str(uuid.uuid4())
|
|
return self.user.app_user_id
|
|
|
|
|
|
@pytest.fixture
|
|
def user():
|
|
return User(email=EMAIL)
|
|
|
|
|
|
@pytest.fixture
|
|
def client(user):
|
|
svc = FakeUserService(user)
|
|
app.dependency_overrides[get_user_service] = lambda: svc
|
|
auth = MagicMock()
|
|
auth.validate_token_full.return_value = AuthResult(
|
|
is_valid=True, user_type=UserType.UNLIMITED, remaining_uses=-1,
|
|
message="ok", user_email=EMAIL, is_admin=False,
|
|
)
|
|
with patch("backend.services.auth_service.get_auth_service", return_value=auth):
|
|
yield TestClient(app)
|
|
app.dependency_overrides.pop(get_user_service, None)
|
|
|
|
|
|
def _me(client):
|
|
r = client.get("/api/users/me", headers={"Authorization": "Bearer tok"})
|
|
assert r.status_code == 200, r.text
|
|
return r.json()
|
|
|
|
|
|
def test_me_mints_app_user_id_once(client):
|
|
first = _me(client)["app_user_id"]
|
|
second = _me(client)["app_user_id"]
|
|
assert first == second
|
|
assert uuid.UUID(first).version == 4
|
|
|
|
|
|
@pytest.mark.parametrize("enabled", [False, True])
|
|
def test_me_capabilities_reflect_flag(client, enabled):
|
|
with patch("backend.api.routes.users.get_settings") as gs:
|
|
gs.return_value.account_deletion_enabled = enabled
|
|
assert _me(client)["capabilities"] == {"account_deletion": enabled}
|
|
|
|
|
|
def test_me_push_prefs_default_true(client, user):
|
|
assert _me(client)["push_prefs"] == {"ready": True, "review": True, "problems": True}
|
|
user.push_prefs = {"review": False, "bogus": False}
|
|
assert _me(client)["push_prefs"] == {"ready": True, "review": False, "problems": True}
|
|
|
|
|
|
def test_expo_push_token_model_validates_platform():
|
|
t = ExpoPushToken(token="ExponentPushToken[x]", platform="ios", device_id="d1")
|
|
assert t.last_used_at is None
|
|
with pytest.raises(ValueError):
|
|
ExpoPushToken(token="t", platform="web", device_id="d")
|
|
|
|
|
|
class _Snap:
|
|
def __init__(self, data):
|
|
self.exists = data is not None
|
|
self._d = data
|
|
|
|
def to_dict(self):
|
|
return self._d
|
|
|
|
|
|
def _service(stored):
|
|
svc = UserService.__new__(UserService)
|
|
svc.db = MagicMock()
|
|
ref = MagicMock()
|
|
ref.get.return_value = _Snap(stored)
|
|
txn = MagicMock()
|
|
svc.db.transaction.return_value = txn
|
|
svc.get_user_doc_ref = lambda email: ref
|
|
return svc, ref, txn
|
|
|
|
|
|
def test_ensure_app_user_id_sets_when_absent_and_keeps_when_present():
|
|
with patch("backend.services.user_service.firestore.transactional", lambda f: f):
|
|
svc, ref, txn = _service({"email": EMAIL})
|
|
minted = svc.ensure_app_user_id(EMAIL)
|
|
assert uuid.UUID(minted).version == 4
|
|
txn.set.assert_called_once_with(ref, {"app_user_id": minted}, merge=True)
|
|
|
|
svc, ref, txn = _service({"email": EMAIL, "app_user_id": "existing-id"})
|
|
assert svc.ensure_app_user_id(EMAIL) == "existing-id"
|
|
txn.set.assert_not_called()
|
|
|
|
|
|
def test_me_skips_minting_when_user_already_has_app_user_id(client, user):
|
|
user.app_user_id = "stored-id"
|
|
with patch.object(FakeUserService, "ensure_app_user_id", side_effect=AssertionError("no txn")):
|
|
assert _me(client)["app_user_id"] == "stored-id"
|
|
|
|
|
|
def test_me_returns_null_app_user_id_when_minting_fails(client, caplog):
|
|
with patch.object(FakeUserService, "ensure_app_user_id", side_effect=RuntimeError("contention")):
|
|
with caplog.at_level("WARNING", logger="backend.api.routes.users"):
|
|
body = _me(client)
|
|
assert body["app_user_id"] is None
|
|
assert body["user"]["email"] == EMAIL
|
|
assert any("app_user_id" in r.message and r.levelname == "WARNING" for r in caplog.records)
|