mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary
Consolidate three separate frontends into a single unified Next.js
application that serves both cloud deployment and local CLI modes.
### Key Changes
- **Unified Frontend**: One Next.js app serves cloud
(gen.nomadkaraoke.com) and local CLI (karaoke-gen)
- **Delete Old Code**: Removed ~70k lines of legacy frontend code
- **UI Fixes**: Edit Modal, Instrumental Review, word timing, and more
- **Simplified URLs**: Direct routes (`/app/jobs/{id}/review`) instead
of complex query strings
## Changes
### Frontend Consolidation
- Add `/app/jobs/{id}/review` route for lyrics review
- Add `/app/jobs/{id}/instrumental` route for instrumental selection
- Migrate lyrics review components from MUI to Radix/Tailwind
- Convert vanilla JS instrumental review to React components
- Add local mode detection (`frontend/lib/local-mode.ts`)
### Local CLI Integration
- Package Next.js static export in `karaoke_gen/nextjs_frontend/out/`
- Update lyrics and instrumental review servers to serve unified
frontend
- Add cloud-compatible API routes (`/api/jobs/local/*`)
- Add SPA routing with Turbopack chunk injection workaround
### Deletions
- Remove `lyrics_transcriber_temp/lyrics_transcriber/frontend/` (~14k
lines)
- Remove `karaoke_gen/instrumental_review/static/index.html`
### Backend Updates
- Simplify email notification URLs to use consolidated routes
- Remove E2E bypass key (no longer needed)
- Update job notification service for new URL format
### UI Fixes
- Edit Modal: width, spacebar handler (Tap To Sync), footer layout
- Word highlight: purple color instead of grey
- Add word timing calculation
- Replace all words functionality
- Instrumental review: smooth 60fps playhead animation
- Success screen with countdown before window close
## Testing
- [x] All 1021 backend tests pass
- [x] All 181 frontend unit tests pass
- [x] Local CLI flow verified end-to-end
- [x] Lyrics review UI functional in browser
- [x] Instrumental review UI functional in browser
## Review
- [x] CodeRabbit CLI review completed locally (manual review due to file
count)
- [x] No security issues found
- [x] Test failures fixed
@coderabbitai ignore
---
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
3.7 KiB
3.7 KiB
Frontend Consolidation Tasks
This directory contains task documents for the frontend consolidation project.
Overview
We're consolidating 3 frontends into 1:
- Main karaoke-gen frontend (keep, extend)
- Lyrics Review frontend (migrate from MUI → Tailwind)
- Instrumental Review frontend (convert from vanilla HTML → React)
Task Status
| Task | Description | Status | Assignee |
|---|---|---|---|
| TASK-001 | Lyrics Review Migration | Ready | - |
| TASK-002 | Instrumental Review Migration | Ready | - |
Execution Order
Tasks can be executed in parallel - they're independent:
┌─────────────────────────────────────────────────────────────┐
│ Phase 1 (Complete) │
│ Route structure + JobCard navigation + placeholders │
└─────────────────────────────────────────────────────────────┘
│
┌───────────────┴───────────────┐
▼ ▼
┌─────────────────────────┐ ┌─────────────────────────┐
│ TASK-001 │ │ TASK-002 │
│ Lyrics Review (~14k) │ │ Instrumental (~1.7k) │
│ Multiple sessions │ │ Single session │
│ recommended │ │ │
└─────────────────────────┘ └─────────────────────────┘
│ │
└───────────────┬───────────────┘
▼
┌─────────────────────────────────────────────────────────────┐
│ Final Integration │
│ - Update E2E tests │
│ - Remove old frontends │
│ - Update documentation │
└─────────────────────────────────────────────────────────────┘
For Agent Sessions
When starting a new agent session:
- Read the relevant task document
- Work in the same worktree:
/Users/andrew/Projects/karaoke-gen-multiagent/karaoke-gen-consolidate-frontends - Follow the migration order specified in the task
- Verify build passes after each tier/milestone
- Update task status when complete
Files Reference
- Plan:
docs/archive/2026-01-09-frontend-consolidation-plan.md - Main worktree:
karaoke-gen-consolidate-frontends/ - Branch:
feat/sess-20260109-1931-consolidate-frontends
Completion Checklist
After all tasks are done:
- TASK-001 complete (Lyrics Review migrated)
- TASK-002 complete (Instrumental Review migrated)
- Build passes:
cd frontend && npm run build - E2E tests updated and passing
- Old frontend code removed:
lyrics_transcriber_temp/lyrics_transcriber/frontend/karaoke_gen/instrumental_review/static/
- Documentation updated
- PR created with
/prcommand