mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary `requests.nomadkaraoke.com` used to 302 to `gen.nomadkaraoke.com/en/requests`, so the short link couldn't be copied out of a mobile address bar (Andrew pastes it into YouTube comment replies). Now the board is served on the vanity host itself. - **New Worker `requests-host`** (`infrastructure/cloudflare/requests-host/`): `/` serves gen's `/en/requests/` (query kept), paths with an extension are proxied from gen, and every other path 302s to the same path on gen. - **Pulumi (already applied):** Worker route `requests.nomadkaraoke.com/*`; old redirect rule removed; DNS comment updated. - **Tenant detection:** `requests` added to the non-tenant subdomains. The browser and Pages Function now share one list (`frontend/lib/edge/nonTenantSubdomains.ts`); the browser copy had drifted and was missing `requests`. Backend list updated to match. - **Board "Make it yourself"** goes to `gen.nomadkaraoke.com/app` when on the vanity host. - **Docs:** runbook rewritten, including why a Pages custom domain didn't work. Attaching the domain bypassed zone redirect rules and served the gen homepage for ~3 min before rollback. ## Testing - `node --test infrastructure/cloudflare/requests-host/`: 4 pass - Jest tenant + new non-tenant list tests: pass. Backend `test_tenant_middleware.py`: 36 pass - `make test`: 6465 pass. 8 fail in `test_emulator_integration.py`, and the same 8 fail on a clean `origin/main` checkout (pre-existing, env-related) - New prod E2E `e2e/production/requests-vanity-host.spec.ts`: board at `/` with no redirect and the API working, other paths 302 to gen. The pass/fail status of the "not a tenant" check (still sends `X-Tenant-ID: requests` until this frontend deploys) is listed below. - Manual browser check on prod: URL stays `requests.nomadkaraoke.com/?utm_source=…`, board renders, no console errors | Prod E2E check | Before this deploy | |---|---| | serves board at `/` | ✅ | | other paths → gen | ✅ | | not treated as tenant | ❌ expected, fixed by this PR | Local CodeRabbit review done (1 minor doc finding, fixed). @coderabbitai ignore 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_016FYpoNVXzJzqKFaowqpwxr --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>