mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary Vocal Star (Matt, April 2025) asked for their own VS catalogue code at the start of every output file, with all files in one folder (e.g. `VS6588 - Gerry and the Pacemakers - Ferry Cross The Mersey`). Tenant operators can now set a per-track **Track code**. It becomes the job's preserved brand code (`keep_brand_code`, which both render paths already honour), so the Dropbox folder and every delivered file use it instead of an allocated `VSTAR-NNNN`. ## Changes - **Backend:** `POST /api/jobs/create-with-upload-urls` accepts `track_code`. - Tenant portals only; `400` elsewhere. - Strict filesystem-safe validation, upper-cased. - Maps to `JobCreate.keep_brand_code`. - **Bulk analyze:** a leading code in filenames (`VS6588 Artist - Title Guide.mp3`) is split off and returned as `track_code`. - Files pair only when code **and** song match. - LLM pairs with conflicting codes are rejected, and the code is stripped from LLM-extracted artists. - **Frontend:** an optional Track code field on the tenant single-track form and on each bulk row. - Client validation mirrors the backend, with a visible error. - Resumed bulk rows keep their code, locked. - 33 locales translated. - Docs: API.md. Version 0.271.0 → 0.272.0. ## Testing - Backend: new tests for endpoint mapping, rejection outside tenants, unsafe codes, normalisation, filename parsing, the band-name false positive (UB40), same-code/different-song and LLM conflicts. - Full backend suite: 5985 passed. The only 30 failures are emulator tests, because the local Firestore emulator wasn't running. - Frontend: full Jest 1680/1680 passing, plus new TenantJobFlow / TenantBulkFlow tests. `tsc` shows no new errors. - Local CodeRabbit: 3 cycles, all real findings fixed. The one remaining note is on a pre-existing string. @coderabbitai ignore 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Gp5fBmsmWJxgkEHb4JfhXR --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
20 lines
771 B
TypeScript
20 lines
771 B
TypeScript
/**
|
|
* Tenant track codes (e.g. Vocal Star's "VS6588") prefix the output folder and
|
|
* every delivered file, so they're kept to a short filesystem-safe token.
|
|
* Mirrors backend `normalize_track_code` in backend/api/routes/file_upload.py.
|
|
*/
|
|
const TRACK_CODE_RE = /^[A-Za-z0-9]+(?:[-_][A-Za-z0-9]+)*$/
|
|
export const TRACK_CODE_MAX_LEN = 24
|
|
|
|
/** True when blank (the code is optional) or a valid code. */
|
|
export function isValidTrackCode(raw: string): boolean {
|
|
const code = raw.trim()
|
|
return !code || (code.length <= TRACK_CODE_MAX_LEN && TRACK_CODE_RE.test(code))
|
|
}
|
|
|
|
/** Cleaned code to send, or undefined when blank. */
|
|
export function normalizeTrackCode(raw: string): string | undefined {
|
|
const code = raw.trim()
|
|
return code ? code.toUpperCase() : undefined
|
|
}
|