mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary - Fix the deploy health check test payload and status value mismatches that prevented blue-green swaps from ever completing - Follow-up to #642 which fixed the error handling / rollback conditions ## Changes - **Missing required fields**: `encode-preview` requires `audio_gcs_path` and `output_gcs_path` but the health check only sent `job_id`, `ass_gcs_path`, and `duration_seconds` (caused HTTP 422). Added a 3-second test audio file and proper output path. - **Status polling mismatch**: Polling checked for `"completed"` but the GCE worker returns `"complete"` — would always time out even on success. - **Submit response mismatch**: Validated against `"completed"` which is never returned — endpoint returns `"accepted"`, `"cached"`, or `"in_progress"`. ## Root Cause The test payload was written based on the plan doc which had an incomplete request schema. The `audio_gcs_path` and `output_gcs_path` fields have been required since the endpoint was first created (PR #200, Jan 2026). The status string mismatch (`"completed"` vs `"complete"`) was likely a typo that was never caught because the request always failed before reaching the polling stage. ## Testing - Previous deploy (#642) confirmed the 422 error and verified rollback now triggers correctly - This fix addresses the payload so the encode test can actually succeed and the swap can complete - Real validation: next deploy after merge @coderabbitai ignore --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>