mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary Companion to the karaoke-decide PR that keeps every live Spotify search result forever (`karaoke_decide.spotify_live_tracks`). With this change, those songs join the daily **song-id export**, which feeds: - the kjbox on-device matcher (`song_id.db`); - decide's song-search service; - the mobile app's offline index. So a song we look up once, like "Cole Phillips – Roll of Dice" (a 2025 release missing from the July 2025 Spotify snapshot and from MusicBrainz), is known everywhere from the next build on, with no Spotify or Gemini call. ## Changes - `kn_data_sync/main.py`: `SPOTIFY_LIVE_UNION` is appended to `SONG_ID_SQL` when the table exists. Before decide's first live search creates it, the union is skipped with an INFO log. - Grouped by lowercased artist/title. - Popularity uses the D5a estimate: 0.8 × the artist's popularity (via `art`), capped at 50, else 30. The API no longer returns track popularity. - Docs: API.md. Version 0.294.2. ## Testing - `test_main.py`: union added when the table exists, skipped when it doesn't, four columns and the estimate (9 passed). - **BigQuery dry run** of the full export with the union (inline row in place of the table): valid, ~8.2 GB scanned (unchanged). - Local CodeRabbit review: 0 findings. ## Deploy The function is deployed by hand: `infrastructure/functions/kn_data_sync/deploy.sh` (`gcloud functions deploy`). CI doesn't deploy it, and it needs `/gcp-admin`. @coderabbitai ignore 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_012RYLVUQ68KFYtZF7vEfhAq Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>