mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary Backlog Frog #6 (YouTube channel → gen funnel). Andrew's spec: *"we could probably also solve that by building some automation to detect youtube comments asking for songs and auto-reply with a link to the requests board"*. An hourly bot reads new top-level comments on the Nomad Karaoke channel and, when someone asks for a song: - **Song already on the channel:** replies with that video's link. - **Otherwise:** adds the song to the requests board (or finds the existing request) and replies with a link straight to it, e.g. `Added "Tiny Hitman" by Bear Ghost to our requests board 🥳 upvote it here and we'll email you when it's made: <link>`. - **Vague asks** ("more Johnnie please") get a generic board link. - **Non-English comments** get a translated reply, which falls back to English if a URL doesn't survive translation. The reply promotes only the board, not gen (Andrew's call). The goal is turning anonymous YouTubers into board users with an email address. **Andrew signed this off on a 6-month local replay** (`scripts/youtube-comments/replay.py`, read-only): - 265 threads, 33 song requests. - It flagged all 29 requests Andrew had answered by hand, and all 7 vague asks. - It posted no replies to non-requests. - His calls on borderline cases became prompt rules: yes to Playa Fly, no to "Joe Cuervo Karaoke 🎤" on an unrelated video. ## Changes - **Decision core:** `backend/services/youtube_comment_bot.py`, a pure module with injectable ports (Gemini classifier/translator, board, channel index), shared by the replay and the worker. - **Worker:** `backend/workers/youtube_comment_bot_worker.py`, called through `POST /api/internal/youtube-comments/run` (`?dry_run=true`). - Creates a create-only action doc per comment **before** posting, so nothing gets a double reply. - Keeps a high-water mark with a 6h overlap. A Gemini error causes a retry, not a permanent skip. - Per-run cap and quota coordination. - Posts to #noise per reply; failures go to #alerts, throttled. - **Kill switch:** `YOUTUBE_COMMENT_AUTOREPLY_ENABLED` defaults to **false**, and this PR leaves it off. A follow-up PR switches it on after a prod dry run. `YOUTUBE_COMMENT_AUTOREPLY_START` enables a one-time backfill of unanswered requests. - **Requests board:** - New `source="youtube_comment"`; bot-added requests are owned by the placeholder `youtube-comment@nomadkaraoke.com` with no votes. - The **first real up-voter claims the request**, inside the vote transaction. The daily picker skips unclaimed requests, so a free credit never goes to the placeholder. - Frontend `?request=<id>` deep link: highlight, scroll, banner (33 locales). - Signing in from the link uses purpose `requests_board:<id>`, so the magic link returns to the request with `&upvote=1` and the upvote is cast once. - **OAuth:** the bot uses its **own** Desktop OAuth client and secret `youtube-comment-bot-credentials` (`youtube` + `youtube.force-ssl`), because Google refuses `force-ssl` in the device flow. The upload token is untouched. - **Infra (Pulumi, already applied locally):** secret container + Cloud Scheduler `youtube-comment-autoreply-hourly`. - **Description template:** a make-your-own line moves above YouTube's "...more" fold (`utm_campaign=make_cta_top`). The daily backfill re-drains the channel over about 11 days. - **Docs:** `docs/REQUESTS-BOARD.md` § YouTube comment auto-reply, API.md, README.md, plus the plan in `docs/archive/2026-10-22-youtube-comment-autoreply-plan.md`. ## Testing - `backend/tests/test_youtube_comment_bot.py` (33): skips, routing, vague asks, translation fallback, malformed classifier output, API helpers. - `backend/tests/test_youtube_comment_bot_worker.py` (12): kill switch, dry run, idempotency (second run and concurrent claim), go-live start, cap, quota, missing scope, post failure, classifier-error retry. - `backend/tests/emulator/test_song_request_service.py`: bot add/dedupe, claim on first upvote, downvote doesn't claim, picker skips unclaimed, human resubmit claims, `find_published_by_key`. - `backend/tests/test_admin_login_link.py`: `requests_board:<id>` redirect and purpose helper. - `frontend/e2e/regression/requests-board-deep-link.spec.ts` (3): highlight + sign-in purpose, upvote-once on return + param dropped, no toggle-off when already upvoted. - Full `make test`: backend 6584 passed; the only failures are the local-environment `test_emulator_integration` cases, which fail identically on `origin/main` (port 8080 is held by another session's emulator). Frontend Jest: 1760 passed. - Behavioural acceptance: the 6-month replay above. @coderabbitai ignore 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_016E3ibN2EcKxnGQvEf6T4V8 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>