mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
@coderabbitai ignore ## Why Andrew: job 5c1d24eb loaded no reference lyrics. LRCLIB and Genius both returned the correct song, but the relevance filter scored them 26% and 25%, below its 30% threshold. Anchor coverage credits a repeated phrase only once, so chorus-heavy songs undercount. The transcription was decent, with a few consistent mishearings. ## What `filter_irrelevant_sources(..., transcribed_text=)` now does a second, **additive** check. A source the anchor filter rejects is kept when its word-trigram overlap with the transcription clears four guards: - **≥ 25%** of reference trigrams matched, repeats counted; - **≥ 20** reference trigrams, so tiny references can't score by chance; - **≥ 10** matches; - **≥ 15 distinct** matched trigrams, so a shared refrain alone can't pass. Trigrams must contain three distinct words, so "na na na" and "oh oh oh" don't count. Tokens are NFC-normalized and keep combining marks. Both call sites pass the transcription: the corrector, which also serves the review UI's lyrics search and add-source flow, and the controller's uncorrected path. Without `transcribed_text`, behaviour is unchanged. The rescue **never rejects** a source the anchor filter keeps. The serialized `rejected_sources` metadata is unchanged. ## Calibration (459 recent production jobs; per-job reference txt vs `(Lyrics Uncorrected).txt`) - **Wrong-song baseline:** 491k cross-job pairs, excluding pairs with the same title. - Worst genuine pair: 9.4%; p99.99: 5.5%. - The only cross-job pairs that pass are one job whose audio is another job's song under a wrong title. Their transcriptions overlap 45%, where unrelated songs score under 10%. - A naive n-gram rule would have admitted a wrong song at 41% through shared "na na" filler. Requiring three distinct words removes it. - **Rescued:** 22 sources that are currently rejected, **all the correct song**, scoring 26–88%. Examples: the 5c1d24eb song, Deacon Blue, UB40, Atomic Kitten, Sezen Aksu, Grateful Dead, Etherwood, Sub Focus, Terry Allen. - **Left rejected by the distinct-trigram guard:** one refrain-only drum & bass track (8 distinct matches; it's the right song but has the risk profile). This was a deliberate, cautious choice. - No lyrics text is committed; the tests use invented lyrics. ## Testing - `tests/correction/test_relevance.py`, 17 passed (8 new): - a repetitive correct song is rescued; - no transcription means unchanged behaviour; - a wrong song is still rejected; - filler doesn't count; - a tiny reference isn't rescued; - a source the anchor filter keeps is never rejected; - a shared refrain alone can't rescue; - combining marks are kept. - `tests/unit`: 2184 passed. Running `tests/unit`, `tests/correction` and the backend review tests together gives the same 12 order-dependent failures on untouched main; they pass separately, as CI runs them. - Local CodeRabbit: 2 cycles. Fixed the combining-marks and distinct-trigram findings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Jw21syo4HizJJjYw2mg2Vp --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>