mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary Alert hygiene, part of keeping Discord #alerts to actionable signal only. ERROR is page-worthy: the error monitor turns every new ERROR pattern into an #alerts message. This PR moves expected conditions down to INFO/WARNING and fixes the one real bug among them, which was a Payment Link checkout crashing the Stripe webhook. It covers the BACKLOG items "Payment Link checkouts crash the Stripe webhook" and part of "Alert-hygiene bundle". ## Changes 1. **Stripe webhook, non-gen checkouts** (`users.py`, `stripe_service.py`, `stripe_admin_service.py`) - A session that gen didn't create (a Stripe Payment Link: `payment_link` is set, there's no gen metadata, and `customer_email=None`) used to log ERROR "No user email in checkout session". `store_payment` then crashed on `None.lower()`, so the payment never reached `stripe_payments` or revenue. - New `StripeService.is_gen_checkout()`. A non-gen checkout now logs INFO "non-gen checkout (payment link ...)" and grants no credits. It is marked processed for idempotency and is still stored, with `customer_details.email`, `order_type="payment_link"`, `payment_link_id` and the line-item description. - `store_payment` now handles None for metadata, customer_details, total_details and payment-method fields. - **Not backfilled:** session `cs_live_a1ENsua3w6mDH04PPc…` (2026-10-13, a $36 tip, no customer action needed). It could be backfilled through an admin path that calls `store_payment` on the expanded session. GCP writes from agents are restricted, so this PR doesn't do it. 2. **Lyrics providers** (`base_lyrics_provider._log_request_exception`): a 404 means "no lyrics for this track" and now logs INFO. 429 moves to WARNING alongside 5xx, connection errors and timeouts. Auth errors and other 4xx stay ERROR. After 5 404s from one provider in a process, it logs a single WARNING saying the provider may be dead (TODO points at the Musixmatch backlog item). 3. **research_audio** (`audio_search.py`): no more `AWAITING_AUDIO_SELECTION -> SEARCHING_AUDIO -> AWAITING_AUDIO_SELECTION` transitions, which were invalid and logged 2 ERRORs per re-search. The job stays in AWAITING_AUDIO_SELECTION with no status writes, so a crashed request can't strand it. After the search the job is re-read. If a selection landed in the meantime, the fresh results are discarded with a 409 instead of replacing the results that selection indexed into. 4. **audio-download-job on a deleted job** (`audio_download_worker.py`): if `get_job()` returns None at the start or after the download, or a failure happens and a fresh read confirms the doc is gone, the worker logs INFO and returns success, so it exits 0. That means no `fail_job`, no further writes, no worker triggers and no Cloud Run retry. A GCS NotFound on a job that still exists stays an ERROR. Seen with job 6ffe88ad on 2026-10-14. 5. **Loop watchdog**: "Failed to record loop stall (non-fatal)" now logs WARNING with exc_info. Only that line changed, to keep the conflict with feat/alert-noise-monitor trivial. 6. **Job-list queries** (`firestore_service.list_jobs`, `list_jobs_summary`, `list_jobs_by_batch_id`): `query.stream()` now gets `retry=` and `timeout=` of 30s. The client default is 300s for both, which caused the "Error listing jobs summary: Timeout of 300.0s exceeded" errors. Version 0.278.9 (0.278.8 is taken by the still-open #1186). ## Testing - New/updated unit tests: - `test_stripe_webhook_non_gen_checkout.py`: webhook stores the payment, logs INFO, logs nothing at ERROR, and marks the session processed. - `test_stripe_admin_service.py`: Payment Link session and null fields. - `tests/unit/test_base_lyrics_provider.py`: log levels for 404, 429 and 401, plus the dead-provider WARNING. - `test_audio_search_research_attach.py`: no status writes, and a selection made mid-search gets a 409. - `test_audio_download_worker.py`: job deleted at start, mid-download, or with NotFound on write. - `test_loop_watchdog.py`: recorder failure logs WARNING. - `test_firestore_list_query_timeout.py`: bounded retry/timeout on all three list queries. - `pytest backend/tests --ignore=backend/tests/emulator`: 6434 passed. `pytest tests/unit`: 2108 passed. - Local CodeRabbit review: cycle 1 raised 2 findings (non-gen session idempotency, re-search race), both fixed. Cycle 2 was clean. @coderabbitai ignore 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_019pmG2XAgtUguEJWLFpkKHN --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>