mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Why Andrew asked whether we can see past community-requests-board submissions and whether our first real user got a video. Investigation surfaced: - **First real user was fully served.** `tas041964@gmail.com` requested *Sam Cooke and the Soul Stirrers – Wonderful* (Sep 15); it was auto-picked, generated, published to YouTube (NOMAD-1650), and he got the completion email + emailed thanks. ✅ - **No admin view existed** to see this — you had to query Firestore directly. - **A real bug:** the community publish fan-out (`mark_published` + voter emails) fired **only** on the `youtube_upload_queue` path. Jobs published via the direct video-worker distribution path (like Sam Cooke's) bypassed it, so the request stayed `in_progress`, never lit up the board's public "Recently made" list, and other up-voters would silently miss their "track is live" email. ## What 1. **Fix the publish transition** — extract the fan-out into `backend/services/community_publish.py` and call it from **both** publish paths (`youtube_queue_processor` + `video_worker`). Also fixes a latent `len(int)` crash in the log line. 2. **Backfill / safety net** — `POST /api/internal/community-requests/reconcile`: idempotent, publishes any `in_progress` pick whose job is already live on YouTube. (Will be run in prod post-deploy to fix the Sam Cooke request.) 3. **Admin history view** — `GET /api/admin/community-requests` + a `/admin/community-requests` page: every request, all statuses, with requester, votes, and job + YouTube links. The public board's "Recently made" section already existed in the UI — it was empty only because of bug #1; fixing the transition (+ reconcile backfill) lights it up. ## Testing - `backend/tests/test_community_voter_notify.py` — fan-out from the shared module, both-path idempotency, voter dedupe/retry, YouTube-url resolution, and the reconcile scan. - `backend/tests/test_community_review_admin.py` — the new admin history endpoint maps all statuses. - All 31 requests-board + 158 worker tests pass. The one unrelated failure in `test_audio_processor_local_gpu.py` is pre-existing (confirmed with changes stashed). ## Notes - Admin surface is English-only (no i18n changes); no `en.json` strings added. - Local CodeRabbit review couldn't run (CLI requires life360-org SSO; no seat on this repo) — leaving to the GitHub bot. Plan: `docs/archive/2026-09-17-requests-board-history-and-publish-transition-plan.md` 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added an admin Community Requests history page covering all statuses, votes, submitters, review details, linked jobs, and YouTube videos. - Added admin reconciliation for eligible requests with live videos. - Added automatic voter email notifications after community-request publication. - **Bug Fixes** - Improved publication handling across direct and queued video workflows. - Added recovery for incomplete voter notifications and missed publication transitions. - **Documentation** - Documented the community-request history and reconciliation API endpoints. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
167 lines
3.4 KiB
TypeScript
167 lines
3.4 KiB
TypeScript
"use client"
|
|
|
|
import Link from "next/link"
|
|
import { usePathname } from "next/navigation"
|
|
import {
|
|
LayoutDashboard,
|
|
Users,
|
|
Briefcase,
|
|
DollarSign,
|
|
ArrowLeft,
|
|
Settings,
|
|
Search,
|
|
ShieldAlert,
|
|
BookOpenCheck,
|
|
Scissors,
|
|
Fingerprint,
|
|
MessageSquare,
|
|
Share2,
|
|
Building2,
|
|
ListChecks,
|
|
History,
|
|
} from "lucide-react"
|
|
|
|
import {
|
|
Sidebar,
|
|
SidebarContent,
|
|
SidebarFooter,
|
|
SidebarGroup,
|
|
SidebarGroupContent,
|
|
SidebarGroupLabel,
|
|
SidebarHeader,
|
|
SidebarMenu,
|
|
SidebarMenuButton,
|
|
SidebarMenuItem,
|
|
SidebarSeparator,
|
|
} from "@/components/ui/sidebar"
|
|
|
|
const navItems = [
|
|
{
|
|
title: "Dashboard",
|
|
href: "/admin",
|
|
icon: LayoutDashboard,
|
|
},
|
|
{
|
|
title: "Users",
|
|
href: "/admin/users",
|
|
icon: Users,
|
|
},
|
|
{
|
|
title: "Jobs",
|
|
href: "/admin/jobs",
|
|
icon: Briefcase,
|
|
},
|
|
{
|
|
title: "Payments",
|
|
href: "/admin/payments",
|
|
icon: DollarSign,
|
|
},
|
|
{
|
|
title: "Referrals",
|
|
href: "/admin/referrals",
|
|
icon: Share2,
|
|
},
|
|
{
|
|
title: "Community Requests",
|
|
href: "/admin/community-requests",
|
|
icon: History,
|
|
},
|
|
{
|
|
title: "Community Reviews",
|
|
href: "/admin/community-reviews",
|
|
icon: ListChecks,
|
|
},
|
|
{
|
|
title: "Tenants",
|
|
href: "/admin/tenants",
|
|
icon: Building2,
|
|
},
|
|
{
|
|
title: "Audio Searches",
|
|
href: "/admin/searches",
|
|
icon: Search,
|
|
},
|
|
{
|
|
title: "Rate Limits",
|
|
href: "/admin/rate-limits",
|
|
icon: ShieldAlert,
|
|
},
|
|
{
|
|
title: "Edit Reviews",
|
|
href: "/admin/edit-reviews",
|
|
icon: BookOpenCheck,
|
|
},
|
|
{
|
|
title: "Audio Edits",
|
|
href: "/admin/audio-edits",
|
|
icon: Scissors,
|
|
},
|
|
{
|
|
title: "Feedback",
|
|
href: "/admin/feedback",
|
|
icon: MessageSquare,
|
|
},
|
|
{
|
|
title: "Abuse Investigation",
|
|
href: "/admin/abuse",
|
|
icon: Fingerprint,
|
|
},
|
|
]
|
|
|
|
export function AdminSidebar() {
|
|
const pathname = usePathname()
|
|
|
|
const isActive = (href: string) => {
|
|
if (href === "/admin") {
|
|
return pathname === "/admin"
|
|
}
|
|
return pathname.startsWith(href)
|
|
}
|
|
|
|
return (
|
|
<Sidebar>
|
|
<SidebarHeader className="border-b border-sidebar-border">
|
|
<div className="flex items-center gap-2 px-2 py-2">
|
|
<Settings className="w-6 h-6 text-primary" />
|
|
<span className="font-semibold text-lg">Admin Panel</span>
|
|
</div>
|
|
</SidebarHeader>
|
|
|
|
<SidebarContent>
|
|
<SidebarGroup>
|
|
<SidebarGroupLabel>Navigation</SidebarGroupLabel>
|
|
<SidebarGroupContent>
|
|
<SidebarMenu>
|
|
{navItems.map((item) => (
|
|
<SidebarMenuItem key={item.href}>
|
|
<SidebarMenuButton asChild isActive={isActive(item.href)}>
|
|
<Link href={item.href}>
|
|
<item.icon className="w-4 h-4" />
|
|
<span>{item.title}</span>
|
|
</Link>
|
|
</SidebarMenuButton>
|
|
</SidebarMenuItem>
|
|
))}
|
|
</SidebarMenu>
|
|
</SidebarGroupContent>
|
|
</SidebarGroup>
|
|
</SidebarContent>
|
|
|
|
<SidebarSeparator />
|
|
|
|
<SidebarFooter>
|
|
<SidebarMenu>
|
|
<SidebarMenuItem>
|
|
<SidebarMenuButton asChild>
|
|
<Link href="/app">
|
|
<ArrowLeft className="w-4 h-4" />
|
|
<span>Back to App</span>
|
|
</Link>
|
|
</SidebarMenuButton>
|
|
</SidebarMenuItem>
|
|
</SidebarMenu>
|
|
</SidebarFooter>
|
|
</Sidebar>
|
|
)
|
|
}
|