mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary Fixes the deployment failure from PR #297 by making lyrics_transcriber a proper subpackage of karaoke_gen instead of a separate vendored library. ### Changes - Move `libs/lyrics_transcriber/` to `karaoke_gen/lyrics_transcriber/` - Update all imports from `from lyrics_transcriber.X` to `from karaoke_gen.lyrics_transcriber.X` - Simplify Dockerfile (no separate `libs/` COPY needed) - Update pyproject.toml to remove separate package entry - Update test mocks and logger names ### Why this is better - Cleaner project structure - one package containing everything - Simpler Dockerfile - just COPY karaoke_gen/ - No confusion about vendored vs internal code ## Test plan - [x] `poetry install` succeeds - [x] All imports work correctly - [x] All 2614 tests pass - [ ] Backend deployment succeeds @coderabbitai ignore Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
43 lines
1.6 KiB
Docker
43 lines
1.6 KiB
Docker
# Fast application image - uses pre-built base with all dependencies
|
|
#
|
|
# The base image (karaoke-backend-base) contains:
|
|
# - Python 3.11, ffmpeg, sox, system deps
|
|
# - All pip dependencies from requirements-frozen.txt (NO code)
|
|
#
|
|
# This Dockerfile adds the actual application code on top.
|
|
# Build time: ~1-2 minutes (deps already cached in base)
|
|
#
|
|
# If the base image doesn't exist yet, build it first:
|
|
# gcloud builds submit --config=cloudbuild-base.yaml --project=nomadkaraoke
|
|
|
|
# Use pre-built base image with all dependencies
|
|
# Override with --build-arg BASE_IMAGE=karaoke-backend-base:local for local testing
|
|
ARG BASE_IMAGE=us-central1-docker.pkg.dev/nomadkaraoke/karaoke-repo/karaoke-backend-base:latest
|
|
FROM ${BASE_IMAGE}
|
|
|
|
# Set working directory (should already exist from base)
|
|
WORKDIR /app
|
|
|
|
# Copy backend code (this is the only thing that changes frequently)
|
|
COPY backend /app/backend
|
|
|
|
# Copy and reinstall karaoke_gen from local source
|
|
# This ensures new modules are included without rebuilding base image
|
|
# Note: lyrics_transcriber is now a subpackage of karaoke_gen
|
|
COPY karaoke_gen /app/karaoke_gen
|
|
COPY pyproject.toml README.md LICENSE /app/
|
|
RUN pip install --no-cache-dir -e .
|
|
|
|
# Set environment variables
|
|
ENV PYTHONUNBUFFERED=1
|
|
ENV PORT=8080
|
|
|
|
# Expose port
|
|
EXPOSE 8080
|
|
|
|
# Run uvicorn directly
|
|
# Note: Transmission daemon removed - torrent downloads now handled by
|
|
# dedicated flacfetch VM service (see docs/00-current-plan/TORRENT-SERVICE-PLAN.md)
|
|
# Using --loop asyncio (instead of uvloop) to support nest_asyncio for remote flacfetch calls
|
|
CMD ["uvicorn", "backend.main:app", "--host", "0.0.0.0", "--port", "8080", "--loop", "asyncio"]
|