Files
karaoke-gen/frontend/components/lyrics-review/EditFeedbackBar.tsx
T
Andrew Beveridge ☄️andClaude Opus 4.6 8c1dfe5460 feat(i18n): Phase 3 frontend — next-intl infrastructure + 1062 strings (en/es/de) (#656)
@coderabbitai ignore

## Summary
- Phase 3 of the i18n multilingual initiative — makes the karaoke-gen
frontend fully multilingual (English, Spanish, German)
- Installs `next-intl` with `[locale]` path-based routing,
LanguageSwitcher, and `Accept-Language` API header
- Extracts **1,062 strings** from ~70 components into `messages/en.json`
across 31 namespaces
- Wires `useTranslations()` into all user-facing components (landing,
dashboard, auth, job flow, lyrics review, instrumental review, audio
editor, etc.)
- Admin pages (`/admin/*`) stay outside locale routing — intentionally
excluded from i18n scope
- Static export generates `/en/`, `/es/`, `/de/` directories (45 total
pages) for Cloudflare Pages
- `es.json`/`de.json` are English placeholders — translation via Gemini
pipeline pending
- Translation pipeline (`scripts/translate.py`) and glossary (55
karaoke-specific terms) included

## Key architecture decisions
- Root layout keeps ThemeProvider/TenantProvider (needed by admin pages
outside `[locale]`)
- Only NextIntlClientProvider added to `[locale]/layout.tsx`
- `job-status.ts` labels converted to translation keys; consumers
translate via `useTranslations('jobStatus')`
- Jest mock loads actual `en.json` so existing tests validate i18n
wiring without assertion changes

## Test plan
- [x] All 707 frontend tests pass (39 suites)
- [x] Static build generates all 45 pages across 3 locales
- [x] Admin pages render at `/admin/` without locale prefix
- [x] CodeRabbit review: 4 issues fixed, 7 pre-existing noted
- [ ] Post-deploy: verify `/en/` landing page renders correctly
- [ ] Post-deploy: verify LanguageSwitcher redirects to `/es/` and
`/de/`
- [ ] Post-deploy: verify `/admin/` still works without locale context

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-03 21:50:53 -04:00

154 lines
4.7 KiB
TypeScript

'use client'
import { useTranslations } from 'next-intl'
import { useEffect, useRef, useCallback } from 'react'
import { Button } from '@/components/ui/button'
import { X } from 'lucide-react'
import type { EditLogEntry, EditFeedbackReason } from '@/lib/lyrics-review/types'
const REASONS_BY_OP: Record<string, { key: string; reason: EditFeedbackReason }[]> = {
word_change: [
{ key: 'misheardWord', reason: 'misheard_word' },
{ key: 'wrongLyrics', reason: 'wrong_lyrics' },
{ key: 'spellingPunctuation', reason: 'spelling_punctuation' },
{ key: 'other', reason: 'other' },
],
word_delete: [
{ key: 'phantomWord', reason: 'phantom_word' },
{ key: 'duplicate', reason: 'duplicate_word' },
{ key: 'misheardWord', reason: 'misheard_word' },
{ key: 'other', reason: 'other' },
],
word_add: [
{ key: 'missingWord', reason: 'missing_word' },
{ key: 'splitWord', reason: 'split_word' },
{ key: 'other', reason: 'other' },
],
}
interface EditFeedbackBarProps {
entry: EditLogEntry | null
visible: boolean
onFeedback: (entryId: string, reason: EditFeedbackReason) => void
onDismiss: () => void
}
export default function EditFeedbackBar({
entry,
visible,
onFeedback,
onDismiss,
}: EditFeedbackBarProps) {
const t = useTranslations('lyricsReview.editFeedback')
const timerRef = useRef<ReturnType<typeof setTimeout> | null>(null)
const entryIdRef = useRef<string | null>(null)
const hoveredRef = useRef(false)
const remainingRef = useRef(10_000)
const startedAtRef = useRef<number | null>(null)
const clearTimer = useCallback(() => {
if (timerRef.current) {
clearTimeout(timerRef.current)
timerRef.current = null
}
}, [])
const startTimer = useCallback((ms: number) => {
clearTimer()
startedAtRef.current = Date.now()
remainingRef.current = ms
timerRef.current = setTimeout(() => {
if (entry) {
onFeedback(entry.id, 'no_response')
onDismiss()
}
}, ms)
}, [clearTimer, entry, onFeedback, onDismiss])
const handleMouseEnter = useCallback(() => {
hoveredRef.current = true
if (timerRef.current && startedAtRef.current !== null) {
const elapsed = Date.now() - startedAtRef.current
remainingRef.current = Math.max(0, remainingRef.current - elapsed)
clearTimer()
}
}, [clearTimer])
const handleMouseLeave = useCallback(() => {
hoveredRef.current = false
if (visible && entry && remainingRef.current > 0) {
startTimer(remainingRef.current)
}
}, [visible, entry, startTimer])
useEffect(() => {
clearTimer()
if (!visible || !entry) return
// If this is a new entry, start the auto-dismiss timer
if (entry.id !== entryIdRef.current) {
entryIdRef.current = entry.id
remainingRef.current = 10_000
if (!hoveredRef.current) {
startTimer(10_000)
}
}
return clearTimer
}, [visible, entry, clearTimer, startTimer])
if (!visible || !entry) return null
const reasons = REASONS_BY_OP[entry.operation] ?? REASONS_BY_OP.word_change
return (
<div
className="fixed bottom-[52px] left-0 right-0 z-40 flex justify-center animate-in slide-in-from-bottom-2 duration-200"
onMouseEnter={handleMouseEnter}
onMouseLeave={handleMouseLeave}
>
<div className="bg-muted/95 backdrop-blur-sm border-t border-b px-4 py-2 flex items-center gap-3 w-full max-w-4xl">
<span className="text-sm text-muted-foreground shrink-0 truncate max-w-[280px]">
{entry.operation === 'word_change'
? t('changed', { before: entry.text_before.trim(), after: entry.text_after.trim() })
: entry.operation === 'word_delete'
? t('removed', { before: entry.text_before.trim() })
: entry.operation === 'word_add'
? t('added', { after: entry.text_after.trim() })
: t('editMade')}
</span>
<div className="flex items-center gap-1.5 flex-wrap">
{reasons.map((r) => (
<Button
key={r.reason}
variant="outline"
size="sm"
className="h-7 text-xs px-2.5"
onClick={() => {
clearTimer()
onFeedback(entry.id, r.reason)
onDismiss()
}}
>
{t(r.key)}
</Button>
))}
</div>
<Button
variant="ghost"
size="sm"
className="h-7 w-7 p-0 ml-auto shrink-0"
onClick={() => {
clearTimer()
onFeedback(entry.id, 'no_response')
onDismiss()
}}
>
<X className="h-3.5 w-3.5" />
</Button>
</div>
</div>
)
}