Files
karaoke-gen/frontend/components/lyrics-review/EditWordList.tsx
T
Andrew Beveridge ☄️andClaude Opus 4.6 8c1dfe5460 feat(i18n): Phase 3 frontend — next-intl infrastructure + 1062 strings (en/es/de) (#656)
@coderabbitai ignore

## Summary
- Phase 3 of the i18n multilingual initiative — makes the karaoke-gen
frontend fully multilingual (English, Spanish, German)
- Installs `next-intl` with `[locale]` path-based routing,
LanguageSwitcher, and `Accept-Language` API header
- Extracts **1,062 strings** from ~70 components into `messages/en.json`
across 31 namespaces
- Wires `useTranslations()` into all user-facing components (landing,
dashboard, auth, job flow, lyrics review, instrumental review, audio
editor, etc.)
- Admin pages (`/admin/*`) stay outside locale routing — intentionally
excluded from i18n scope
- Static export generates `/en/`, `/es/`, `/de/` directories (45 total
pages) for Cloudflare Pages
- `es.json`/`de.json` are English placeholders — translation via Gemini
pipeline pending
- Translation pipeline (`scripts/translate.py`) and glossary (55
karaoke-specific terms) included

## Key architecture decisions
- Root layout keeps ThemeProvider/TenantProvider (needed by admin pages
outside `[locale]`)
- Only NextIntlClientProvider added to `[locale]/layout.tsx`
- `job-status.ts` labels converted to translation keys; consumers
translate via `useTranslations('jobStatus')`
- Jest mock loads actual `en.json` so existing tests validate i18n
wiring without assertion changes

## Test plan
- [x] All 707 frontend tests pass (39 suites)
- [x] Static build generates all 45 pages across 3 locales
- [x] Admin pages render at `/admin/` without locale prefix
- [x] CodeRabbit review: 4 issues fixed, 7 pre-existing noted
- [ ] Post-deploy: verify `/en/` landing page renders correctly
- [ ] Post-deploy: verify LanguageSwitcher redirects to `/es/` and
`/de/`
- [ ] Post-deploy: verify `/admin/` still works without locale context

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-03 21:50:53 -04:00

375 lines
11 KiB
TypeScript

'use client'
import { useTranslations } from 'next-intl'
import { useState, memo, useMemo } from 'react'
import { Button } from '@/components/ui/button'
import { Input } from '@/components/ui/input'
import { Label } from '@/components/ui/label'
import { Trash2, Split, Wand2 } from 'lucide-react'
import { Word } from '@/lib/lyrics-review/types'
import WordDivider from './WordDivider'
import TimeInput from './TimeInput'
interface EditWordListProps {
words: Word[]
onWordUpdate: (index: number, updates: Partial<Word>) => void
onSplitWord: (index: number) => void
onMergeWords: (index: number) => void
onAddWord: (index?: number) => void
onRemoveWord: (index: number) => void
onReplaceAllWords?: (replacementText: string) => void
onSplitSegment?: (wordIndex: number) => void
onAddSegment?: (beforeIndex: number) => void
onMergeSegment?: (mergeWithNext: boolean) => void
isGlobal?: boolean
}
// Memoized word row component
const WordRow = memo(function WordRow({
word,
index,
onWordUpdate,
onSplitWord,
onRemoveWord,
wordsLength,
onTabNavigation,
isMobile,
}: {
word: Word
index: number
onWordUpdate: (index: number, updates: Partial<Word>) => void
onSplitWord: (index: number) => void
onRemoveWord: (index: number) => void
wordsLength: number
onTabNavigation: (currentIndex: number) => void
isMobile: boolean
}) {
const t = useTranslations('lyricsReview.editWordList')
const handleKeyDown = (e: React.KeyboardEvent) => {
if (e.key === 'Tab' && !e.shiftKey) {
e.preventDefault()
onTabNavigation(index)
}
}
return (
<div
className={`flex ${isMobile ? 'flex-col gap-2' : 'flex-row gap-4'} items-${isMobile ? 'stretch' : 'end'} py-1`}
>
{/* Word text field */}
<div className={`flex gap-2 items-end ${isMobile ? '' : 'flex-1'}`}>
<div className="flex-1">
<Label htmlFor={`word-text-${index}`} className="text-xs text-muted-foreground mb-1">
{t('wordLabel', { index })}
</Label>
<Input
id={`word-text-${index}`}
value={word.text}
onChange={(e) => onWordUpdate(index, { text: e.target.value })}
onKeyDown={handleKeyDown}
className="h-8"
/>
</div>
{/* Action buttons inline with word on mobile */}
{isMobile && (
<>
<Button
variant="ghost"
size="icon"
onClick={() => onSplitWord(index)}
title={t('splitWord')}
className="h-8 w-8 text-primary"
>
<Split className="h-4 w-4" />
</Button>
<Button
variant="ghost"
size="icon"
onClick={() => onRemoveWord(index)}
disabled={wordsLength <= 1}
title={t('removeWord')}
className="h-8 w-8 text-destructive"
>
<Trash2 className="h-4 w-4" />
</Button>
</>
)}
</div>
{/* Time fields */}
<div
className={`flex gap-2 items-end ${isMobile ? 'justify-start' : 'justify-end'}`}
>
<TimeInput
value={word.start_time ?? null}
onChange={(val) => onWordUpdate(index, { start_time: val ?? undefined })}
label={t('start')}
widthClass={isMobile ? 'w-20' : 'w-24'}
/>
<TimeInput
value={word.end_time ?? null}
onChange={(val) => onWordUpdate(index, { end_time: val ?? undefined })}
label={t('end')}
widthClass={isMobile ? 'w-20' : 'w-24'}
/>
{/* Action buttons on desktop only */}
{!isMobile && (
<>
<Button
variant="ghost"
size="icon"
onClick={() => onSplitWord(index)}
title={t('splitWord')}
className="h-8 w-8 text-primary"
>
<Split className="h-4 w-4" />
</Button>
<Button
variant="ghost"
size="icon"
onClick={() => onRemoveWord(index)}
disabled={wordsLength <= 1}
title={t('removeWord')}
className="h-8 w-8 text-destructive"
>
<Trash2 className="h-4 w-4" />
</Button>
</>
)}
</div>
</div>
)
})
// Memoized word item component
const WordItem = memo(function WordItem({
word,
index,
onWordUpdate,
onSplitWord,
onRemoveWord,
onAddWord,
onMergeWords,
onSplitSegment,
onAddSegment,
onMergeSegment,
wordsLength,
isGlobal,
onTabNavigation,
isMobile,
}: {
word: Word
index: number
onWordUpdate: (index: number, updates: Partial<Word>) => void
onSplitWord: (index: number) => void
onRemoveWord: (index: number) => void
onAddWord: (index: number) => void
onMergeWords: (index: number) => void
onSplitSegment?: (index: number) => void
onAddSegment?: (index: number) => void
onMergeSegment?: (mergeWithNext: boolean) => void
wordsLength: number
isGlobal: boolean
onTabNavigation: (currentIndex: number) => void
isMobile: boolean
}) {
return (
<div key={word.id}>
<WordRow
word={word}
index={index}
onWordUpdate={onWordUpdate}
onSplitWord={onSplitWord}
onRemoveWord={onRemoveWord}
wordsLength={wordsLength}
onTabNavigation={onTabNavigation}
isMobile={isMobile}
/>
{/* Word divider */}
{!isGlobal && (
<WordDivider
onAddWord={() => onAddWord(index)}
onMergeWords={() => onMergeWords(index)}
onSplitSegment={() => onSplitSegment?.(index)}
onAddSegmentAfter={
index === wordsLength - 1 ? () => onAddSegment?.(index + 1) : undefined
}
onMergeSegment={index === wordsLength - 1 ? () => onMergeSegment?.(true) : undefined}
canMerge={index < wordsLength - 1}
isLast={index === wordsLength - 1}
/>
)}
{isGlobal && (
<WordDivider
onAddWord={() => onAddWord(index)}
onMergeWords={index < wordsLength - 1 ? () => onMergeWords(index) : undefined}
canMerge={index < wordsLength - 1}
/>
)}
</div>
)
})
export default function EditWordList({
words,
onWordUpdate,
onSplitWord,
onMergeWords,
onAddWord,
onRemoveWord,
onReplaceAllWords,
onSplitSegment,
onAddSegment,
onMergeSegment,
isGlobal = false,
}: EditWordListProps) {
const t = useTranslations('lyricsReview.editWordList')
// Simple mobile detection
const isMobile = typeof window !== 'undefined' && window.innerWidth < 640
const [replacementText, setReplacementText] = useState('')
const [page, setPage] = useState(1)
const pageSize = isGlobal ? 50 : words.length
const handleReplaceAllWords = () => {
if (onReplaceAllWords) {
// Use the callback that handles proper timing
onReplaceAllWords(replacementText)
} else {
// Fallback: just update text of existing words (legacy behavior)
const newWords = replacementText.trim().split(/\s+/)
newWords.forEach((text, index) => {
if (index < words.length) {
onWordUpdate(index, { text })
}
})
}
setReplacementText('')
}
// Pagination
const pageCount = Math.ceil(words.length / pageSize)
const startIndex = (page - 1) * pageSize
const endIndex = Math.min(startIndex + pageSize, words.length)
const visibleWords = useMemo(() => {
return isGlobal ? words.slice(startIndex, endIndex) : words
}, [words, isGlobal, startIndex, endIndex])
// Tab navigation between word fields
const handleTabNavigation = (currentIndex: number) => {
const nextIndex = (currentIndex + 1) % words.length
if (isGlobal && (nextIndex < startIndex || nextIndex >= endIndex)) {
const nextPage = Math.floor(nextIndex / pageSize) + 1
setPage(nextPage)
setTimeout(() => {
focusWordTextField(nextIndex)
}, 50)
} else {
focusWordTextField(nextIndex)
}
}
const focusWordTextField = (index: number) => {
const element = document.getElementById(`word-text-${index}`)
if (element) {
const input = element as HTMLInputElement
input.focus()
input.select()
}
}
return (
<div className="flex flex-col gap-2 flex-grow min-h-0">
{/* Initial divider */}
{!isGlobal && (
<WordDivider
onAddWord={() => onAddWord(-1)}
onAddSegmentBefore={() => onAddSegment?.(0)}
onMergeSegment={() => onMergeSegment?.(false)}
isFirst={true}
/>
)}
{isGlobal && <WordDivider onAddWord={() => onAddWord(-1)} />}
{/* Word list with scrolling */}
<div className="flex flex-col gap-1 flex-grow overflow-y-auto mb-0 pt-2 scrollbar-thin">
{visibleWords.map((word, visibleIndex) => {
const actualIndex = isGlobal ? startIndex + visibleIndex : visibleIndex
return (
<WordItem
key={word.id}
word={word}
index={actualIndex}
onWordUpdate={onWordUpdate}
onSplitWord={onSplitWord}
onRemoveWord={onRemoveWord}
onAddWord={onAddWord}
onMergeWords={onMergeWords}
onSplitSegment={onSplitSegment}
onAddSegment={onAddSegment}
onMergeSegment={onMergeSegment}
wordsLength={words.length}
isGlobal={isGlobal}
onTabNavigation={handleTabNavigation}
isMobile={isMobile}
/>
)
})}
</div>
{/* Pagination controls */}
{isGlobal && pageCount > 1 && (
<div className="flex justify-center items-center gap-2 mb-2">
<Button
variant="outline"
size="sm"
onClick={() => setPage((p) => Math.max(1, p - 1))}
disabled={page === 1}
>
{t('previous')}
</Button>
<span className="text-sm">
{t('pageCount', { current: page, total: pageCount })}
</span>
<Button
variant="outline"
size="sm"
onClick={() => setPage((p) => Math.min(pageCount, p + 1))}
disabled={page === pageCount}
>
{t('next')}
</Button>
<span className="text-sm text-muted-foreground ml-2">
{t('wordsRange', { start: startIndex + 1, end: endIndex, total: words.length })}
</span>
</div>
)}
{/* Replace all words */}
<div className="flex gap-2 mb-1">
<Input
value={replacementText}
onChange={(e) => setReplacementText(e.target.value)}
onKeyDown={(e) => {
if (e.key === 'Enter' && replacementText.trim()) {
e.preventDefault()
e.stopPropagation()
handleReplaceAllWords()
}
}}
placeholder={t('replaceAllWords')}
className="flex-grow"
/>
<Button onClick={handleReplaceAllWords} size="sm" className="whitespace-nowrap">
<Wand2 className="h-4 w-4 mr-1" />
{t('replaceAll')}
</Button>
</div>
</div>
)
}