mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary
Two review-UI improvements, both driven from real reviewing pain:
### 1. New "Waveforms" mode in Synced Lyrics
A third view (alongside Simple/Advanced) that renders a **compact inline
copy of the Edit Segment timeline for every segment** — so you can spot
mis-timed words (e.g. an over-long trailing word whose vocal energy died
earlier) at a glance without opening a modal per line.
- Reuses the modal's `TimelineEditor`: resizable/draggable word bars
over each segment's vocal waveform, with the 1s buffer padding,
start/end boundary lines, and greyed read-only neighbour words.
- **Drag** a bar body moves timing; **drag** an edge resizes; both
commit on release (a 4px threshold distinguishes drag from click). A
plain **click** on a word — or the index/✎ — opens the Edit modal.
**Trash** deletes the segment (matches Advanced).
- Bars colour-code with the **exact `HIGHLIGHT_CLASSES` tints** the
Advanced pills use (anchor/gap/corrected/AI/edited) and show the
struck-through **AI-correction ghost text** above corrected bars.
- Tight vertical density (~39px/segment: 20px bars + 14px waveform + 5px
gap) to stay close to Advanced.
- View mode persists to `localStorage` (`lyricsReviewViewMode`,
migrating the old `lyricsReviewAdvancedMode` boolean).
- Advanced + Waveforms now size the **Reference column to its longest
line** so Synced gets the freed width (no more ~25% wasted space).
### 2. Preview modal always shows the backing-vocals waveform
Previously the backing-vocals waveform only appeared *after* switching
away from the recommended "Clean instrumental", making it easy to accept
clean without ever seeing/hearing the backing vocals you'd lose. Now
it's **always shown** whenever a playable backing stem exists, with
selection-aware wording ("kept" vs "removed — click to hear what you'd
be leaving out"). Clicking still auditions the backing track without
changing the final choice.
### Also
- Fixes a pre-existing `Header` `FORMATTING_ERROR` (`autoCorrectedDesc`
rendered without its `count` param on jobs with ≥1 auto-correction).
- `scripts/list-review-jobs.py` — lists in-review jobs with
ready-to-open local review URLs.
## Testing
- New unit tests: `contextWords`, `segmentTiming` (recompute + view-mode
migration), `wordDecorations` (classifier + palette),
`WaveformSegmentRow` (control wiring + untimed fallback).
- Updated `ReviewChangesModal` tests for the always-show behavior +
reworded copy.
- Full frontend Jest suite green (104 suites / 1283 tests).
- i18n: all 33 locales translated; stale key pruned; parity validated.
- Verified live against a real in-review prod job (Playwright):
coloring, ghost text, click-to-open, compact layout, dynamic columns.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Added a Waveforms view to Synced Lyrics for inline word-timing
adjustments.
- Added controls to edit segments, play timed segments, delete segments,
and handle untimed lyrics.
- Waveform bars now visually distinguish corrections, edits, gaps, and
related word states.
- Backing-vocal waveforms remain available for review even when the
clean instrumental is selected.
- **Improvements**
- Auto-correction messaging now displays the number of applied
corrections.
- Clarified backing-vocal and clean-instrumental guidance across
supported languages.
- Updated the application version to 0.227.0.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>