mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary Follow-up to #1101, found while verifying it on prod (job ca2e881a, English song → Japanese): when a long lyric line is split across rows, its translation is shared between the pieces, and unspaced scripts were cut at an arbitrary character — e.g. 無|駄 ("waste") across two rows, worse in portrait. `split_text_proportionally` now scores each split point for unspaced scripts: free after punctuation (、。!?…), cheap after a Japanese particle (を は が に…) or before a kanji/katakana word start following hiragana, a full "part" of cost for a mid-word cut. It also never leaves a piece empty when there are enough characters. Before → after (real prod line): `ねえ、おかしいでしょ、無` / `駄な時間を省いてあげる` → `ねえ、おかしいでしょ、` / `無駄な時間を省いてあげる`. Thai can still split inside a word (no word-boundary data without a dictionary). ## Testing - New unit tests for the prod case and a particle-boundary case; all 201 lyrics output tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved how translated lyrics are split across rows for unspaced text. Splits now favor punctuation and natural language boundaries, helping avoid cutting through words where possible. * Thai text may still be split within words. * **Chores** * Updated the project version to 0.260.1. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>