mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
- Fix Discord webhook URL validation to strip trailing whitespace/newlines
that can be introduced from environment variables or secrets (fixes %0A error)
- Make Discord notification failures non-fatal - log error and continue
- Add --retry CLI command to retry failed jobs from last checkpoint
- Add POST /api/jobs/{job_id}/retry endpoint for retrying failed jobs
- Bump version to 0.71.17
The root cause was environment variables or secrets containing trailing
newline characters (\n) which get URL-encoded as %0A, breaking Discord
API authentication.
22 lines
697 B
Plaintext
22 lines
697 B
Plaintext
---
|
|
description: Git branching and PR workflow
|
|
alwaysApply: true
|
|
---
|
|
|
|
# Branching Workflow
|
|
|
|
**Never commit directly to `main`.** Always work on a feature branch.
|
|
|
|
Create descriptive branch names like `feature/add-discord-notifications`, `fix/audio-sync-issue`, or `refactor/cleanup-api-routes`.
|
|
|
|
# Creating a Pull Request
|
|
|
|
Once all changes are complete, tests pass, and commits are pushed, create a PR with:
|
|
|
|
1. **Summary** - Brief overview of the changes
|
|
2. **Changes Made** - List of specific modifications
|
|
3. **Testing** - How changes were tested (unit tests, manual testing)
|
|
4. **Related Issues** - Reference any GitHub issues (e.g., "Fixes #123")
|
|
|
|
Only merge after review and CI checks pass.
|