mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary Follow-ups from Andrew's test of translated lyrics (job 948b6760), plus a review-page UX gap found while investigating that job. - **Translation row is now secondary:** it renders at 70% of the unsung colour's opacity, with outline and shadow faded to match. A theme's `karaoke.translation_color` still wins. (`subtitles.py:TRANSLATION_OPACITY`) - **YouTube label:** published videos with translations get "(With Translation into X)" in the title, before "(Karaoke)". Only the artist/title get truncated, never the label. The description gets an up-front notice. This covers the live upload and the quota queue, and applies only when `state_data.lyrics_translation.status == "translated"`. Turning translation off and re-rendering clears the outcome. - **Review preview modal:** an always-visible note explains the preview is a quick black-background sync check, not the final look. Jobs with a translation language also get a note that translations are added after review. - **Waveforms toggle:** shows a spinner and tooltip while audio separation is still producing the vocal stem (peaks endpoint returns 202). Previously the rows just stayed empty. ## Testing - Jest: lyrics-review suite (245+) incl. new TranscriptionView/Preview/loader tests - pytest: youtube description/queue/orchestrator, lyrics_translation, translated-lyrics unit tests - Linux libass render tests (Debian + prod static ffmpeg) pass - Independent review agent: 2 findings fixed (Tooltip data-state clobbering toggle state; stale translation outcome) No local CodeRabbit run (CLI has no seat on this org), so leaving this open to the CodeRabbit bot. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * YouTube titles and descriptions now identify the language of translated lyrics. Titles are kept within the platform’s length limit. * Translated lyrics appear with softer opacity by default. * The lyric-review screen explains how the quick preview differs from the final video, including that translated lyrics are added after review. * A spinner and notice indicate when vocal waveforms are still being prepared. * **Bug Fixes** * Translation status now reflects when translation is turned off, preventing stale translated-language labels. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>