mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
@coderabbitai ignore ## Two final render blockers (found by the Vocal Star E2E) With attribution (#824), the audio slot (#825), and transcription padding (#826) fixed, the first real tenant job advanced through transcription → screens → review → render, surfacing the last two never-exercised issues: ### 1. Render prerequisites — "No instrumental selected" existing-instrumental jobs (every tenant submission) have no instrumental-selection UI step, so `instrumental_selection` was never written to state_data. The video orchestrator then defaults to `'clean'` (a separated stem that was never produced for these jobs), and `_validate_prerequisites` rejects the job, leaving it stuck retrying. **Fix:** `complete-review` now defaults `instrumental_selection` to `'custom'` (use the provided instrumental) when `existing_instrumental_gcs_path` is set. An explicit request value still wins. The render path already supports `'custom'`. ### 2. Theme asset paths (reproducibility) The tenant setup scripts wrote full `gs://bucket/themes/.../assets/X` URLs, but `theme_service._build_style_assets_mapping` only resolves bare basenames (the consumer convention). With `gs://` URLs, `style_assets` came back empty → assets never downloaded → encoder failed with "Video background image not found". Scripts now emit basenames, and add the newly-required `extra_text_text_transform` field the strict theme validator expects. (The two live GCS themes — vocalstar, singa — were corrected out-of-band to match.) ## Testing - New regression tests: complete-review defaults to `custom` for existing-instrumental jobs; explicit selection still wins. - Review suites green (102). Full E2E re-run to completion after deploy. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>