Files
karaoke-gen/tests
Andrew Beveridge ☄️andClaude Opus 5.5 fc05571779 fix(theme-preview): skip ffprobe for no-audio ASS generation (v0.249.1) (#1084)
## Summary
Error-monitor alert: `Failed to get audio duration: ...
/tmp/theme-preview-*/no-audio.flac`. The tenant theme editor (#1080)
passed a nonexistent audio path to `SubtitlesGenerator.generate_ass`, so
every uncached preview ran ffprobe on a missing file and logged at ERROR
before falling back to the segment-derived duration. Previews rendered
fine (200); this was pure log noise.

## Changes
- `generate_ass` / `_get_audio_duration` accept `audio_filepath=None` →
skip ffprobe, use `last segment end + 30s` silently. Real-audio callers
unchanged (a failing probe still logs ERROR).
- `theme_preview_service` passes `None`.
- Version 0.249.0 → 0.249.1.

## Testing
- New
`tests/unit/lyrics_transcriber/output/test_subtitles_audio_duration.py`
(None path: no probe, no error log; failed probe still logs;
`generate_ass(..., None)` end-to-end).
- `make test-unit test-backend-unit`: 1846 + 5016 passed.
- Local CodeRabbit review: no findings.

@coderabbitai ignore

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-09-29 16:34:46 -04:00
..