From e528cd4780832f359438769e8674bd7419f461d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herv=C3=A9=20BREDIN?= Date: Wed, 8 Oct 2025 10:07:26 +0200 Subject: [PATCH] improve: warn (instead of raise) on unsupported arguments --- CHANGELOG.md | 1 + src/pyannote/audio/pipelines/speaker_diarization.py | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 80a1efb6..4068e973 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - feat: allow passing preloaded pipeline config to `get_pipeline` - fix: relax version constraint on OpenTelemetry dependencies - setup: update pyannoteai-sdk dependency +- improve: warn (instead of raise) when passing unsupported arguments to speaker diarization pipeline ## Version 4.0.0 (2025-09-29) diff --git a/src/pyannote/audio/pipelines/speaker_diarization.py b/src/pyannote/audio/pipelines/speaker_diarization.py index 3b80033d..e197d031 100644 --- a/src/pyannote/audio/pipelines/speaker_diarization.py +++ b/src/pyannote/audio/pipelines/speaker_diarization.py @@ -534,6 +534,7 @@ class SpeakerDiarization(SpeakerDiarizationMixin, Pipeline): min_speakers: Optional[int] = None, max_speakers: Optional[int] = None, hook: Optional[Callable] = None, + **kwargs, ) -> DiarizeOutput | Annotation: """Apply speaker diarization @@ -561,6 +562,12 @@ class SpeakerDiarization(SpeakerDiarizationMixin, Pipeline): output : DiarizeOutput (or Annotation if `self.legacy` is True) """ + # warn about unsupported kwargs + if len(kwargs) > 0: + warnings.warn( + f"Ignoring unexpected keyword arguments: {', '.join(list(kwargs.keys()))}" + ) + # setup hook (e.g. for debugging purposes) hook = self.setup_hook(file, hook=hook)