From 2c63ae542051939bdc0a17a87f7cf489d482ab31 Mon Sep 17 00:00:00 2001 From: translator Date: Mon, 30 Mar 2026 17:01:52 +0900 Subject: [PATCH] Updates. --- SUMMARIES.md => SUMMARIES (Claude).md | 14 +++++ backend/routers/projects.py | 19 ++++++ backend/services/project_assets_service.py | 31 ++++++++++ backend/services/project_service.py | 1 + frontend/src/api/client.ts | 9 +++ frontend/src/pages/ProjectDetail.tsx | 67 +++++++++++++++++++++- 6 files changed, 140 insertions(+), 1 deletion(-) rename SUMMARIES.md => SUMMARIES (Claude).md (99%) diff --git a/SUMMARIES.md b/SUMMARIES (Claude).md similarity index 99% rename from SUMMARIES.md rename to SUMMARIES (Claude).md index e2eeddd..6aa8106 100644 --- a/SUMMARIES.md +++ b/SUMMARIES (Claude).md @@ -1926,3 +1926,17 @@ This pre-hides all spans so the backward fill takes effect without the one-frame **Result:** - Stroke and shadow controls now affect Video mode text consistently, matching user expectations from other preview modes. + +--- + +### 2026-03-27 — Add stem delete (trashcan) button to project detail + +Added end-to-end stem deletion: + +- **`backend/services/project_assets_service.py`**: new `delete_project_stem(project, stem_name)` — removes the file from disk (if present) and pops the entry from the separation job's file list in the DB. +- **`backend/services/project_service.py`**: re-exported `delete_project_stem` through the compatibility facade. +- **`backend/routers/projects.py`**: new `DELETE /api/projects/{project_id}/stem` endpoint with `DeleteStemRequest` body `{ stem_name }`. +- **`frontend/src/api/client.ts`**: new `deleteStem(projectId, stemName)` API helper. +- **`frontend/src/pages/ProjectDetail.tsx`**: new `StemDeleteButton` component — shows trashcan icon, prompts inline confirmation (checkmark / X) before calling the API. Added to each stem row in `StemsSection` alongside the existing rename and reprocess buttons. + +Also updated SUMMARIES path in memory from `SUMMARIES.md` → `SUMMARIES (Claude).md`. diff --git a/backend/routers/projects.py b/backend/routers/projects.py index 7d29a03..faaa26c 100755 --- a/backend/routers/projects.py +++ b/backend/routers/projects.py @@ -15,6 +15,7 @@ from ..config import DEFAULT_TRANSCRIBE_MODE from ..services.project_service import ( cleanup_all_lrc_output_files, cleanup_rename_all_project_stems, + delete_project_stem, enqueue_project_abc_conversion, enqueue_project_lyric_transcription, enqueue_project_lrc_alignment, @@ -300,6 +301,24 @@ def rename_stem_endpoint(project_id: str, body: RenameStemRequest): raise HTTPException(status_code=exc.status_code, detail=exc.detail) from exc +# --------------------------------------------------------------------------- +# Stem Delete +# --------------------------------------------------------------------------- + +class DeleteStemRequest(BaseModel): + stem_name: str + + +@router.delete("/{project_id}/stem") +def delete_stem_endpoint(project_id: str, body: DeleteStemRequest): + """Delete a stem file from disk and remove it from the job record.""" + project = _get_project_or_404(project_id) + try: + return delete_project_stem(project, body.stem_name) + except ProjectOperationError as exc: + raise HTTPException(status_code=exc.status_code, detail=exc.detail) from exc + + # --------------------------------------------------------------------------- # Stem Rescan # --------------------------------------------------------------------------- diff --git a/backend/services/project_assets_service.py b/backend/services/project_assets_service.py index 3e94d45..d963f0d 100644 --- a/backend/services/project_assets_service.py +++ b/backend/services/project_assets_service.py @@ -190,6 +190,37 @@ def rename_project_stem(project: dict, stem_name: str, new_name: str) -> dict: } +def delete_project_stem(project: dict, stem_name: str) -> dict: + """Delete a tracked stem file from disk and remove it from the separation job record.""" + sep_job = jobs_repo.get(project["sep_job_id"]) + if sep_job is None: + raise ProjectOperationError(404, "Separation job not found") + + stem_files = list(sep_job.get("files", [])) + stem_file = None + stem_idx = None + for index, file_entry in enumerate(stem_files): + if file_entry.get("stem") == stem_name or file_entry.get("name") == stem_name: + stem_file = file_entry + stem_idx = index + break + + if stem_file is None or stem_idx is None: + raise ProjectOperationError(404, f"Stem not found: {stem_name}") + + stem_path = Path(stem_file["path"]) + if stem_path.exists(): + try: + stem_path.unlink() + except Exception as exc: + raise ProjectOperationError(500, f"Failed to delete stem file: {exc}") from exc + + stem_files.pop(stem_idx) + jobs_repo.update(project["sep_job_id"], files=stem_files) + + return {"success": True, "deleted": stem_name} + + def rescan_project_stems(project: dict, audio_exts: set[str]) -> dict: """Register untracked audio files under the project's Stems directory.""" sep_job = jobs_repo.get(project["sep_job_id"]) diff --git a/backend/services/project_service.py b/backend/services/project_service.py index 027caf1..025e928 100644 --- a/backend/services/project_service.py +++ b/backend/services/project_service.py @@ -7,6 +7,7 @@ from .. import job_manager as jm # noqa: F401 from .project_assets_service import ( build_project_detail, collect_related_job_ids, + delete_project_stem, delete_project_with_related_jobs, get_project_cover_art, get_project_or_raise, diff --git a/frontend/src/api/client.ts b/frontend/src/api/client.ts index e6ead86..77a6c2a 100755 --- a/frontend/src/api/client.ts +++ b/frontend/src/api/client.ts @@ -653,6 +653,15 @@ export const renameStem = ( }), }) +// ---------- Stem Delete ---------- + +export const deleteStem = (projectId: string, stemName: string) => + request<{ success: boolean; deleted: string }>(`${BASE}/projects/${projectId}/stem`, { + method: 'DELETE', + headers: { 'Content-Type': 'application/json' }, + body: JSON.stringify({ stem_name: stemName }), + }) + // ---------- Per-Instrument Models ---------- export const getPerInstrumentModels = () => diff --git a/frontend/src/pages/ProjectDetail.tsx b/frontend/src/pages/ProjectDetail.tsx index e2731af..d6222fd 100755 --- a/frontend/src/pages/ProjectDetail.tsx +++ b/frontend/src/pages/ProjectDetail.tsx @@ -7,7 +7,7 @@ import { ListMusic, Edit2, Check, X as XIcon, Wand2, RotateCcw, Copy, Users, Play, Pause, Square, Eye, EyeOff, } from 'lucide-react' -import { getProjectDetail, transcribeProject, abcProject, mixProject, lrcProject, lyricTranscribeProject, downloadUrl, reprocessStem, renameStem, getPerInstrumentModels, getTranscribeModes, getLyricModels, projectCoverArtUrl } from '../api/client' +import { getProjectDetail, transcribeProject, abcProject, mixProject, lrcProject, lyricTranscribeProject, downloadUrl, reprocessStem, renameStem, deleteStem, getPerInstrumentModels, getTranscribeModes, getLyricModels, projectCoverArtUrl } from '../api/client' import type { ProjectDetail as PD, Job, JobFile, ModeOption, LyricModelsPayload } from '../types' import DynamicMixPlayer from '../components/DynamicMixPlayer' import LyricsLivePreview from '../components/LyricsLivePreview' @@ -893,6 +893,66 @@ function StemRenameButton({ ) } +// ─── Stem delete component ────────────────────────────────────────────────── + +function StemDeleteButton({ + projectId, + stemName, + onDelete, +}: { + projectId: string + stemName: string + onDelete: () => void +}) { + const [confirming, setConfirming] = useState(false) + const [busy, setBusy] = useState(false) + + async function handleDelete() { + setBusy(true) + try { + await deleteStem(projectId, stemName) + onDelete() + } catch (e) { + console.error('Delete failed:', e) + } finally { + setBusy(false) + setConfirming(false) + } + } + + if (confirming) { + return ( +
+ + +
+ ) + } + + return ( + + ) +} + // ─── Stems section ────────────────────────────────────────────────────────── function StemsSection({ @@ -1108,6 +1168,11 @@ function StemsSection({ stemName={f.stem ?? f.name} onReprocess={onAction} /> + ))}