mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
fix(replay): show unsaved verdict changes (CodeRabbit); version 0.292.0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012RYLVVVPsvPbXFhRYY5VSJ
This commit is contained in:
1 parent
8a4c473d2d
commit
83071e1df4
3 files changed
+18
-6
No files matched your search
@@ -617,6 +617,7 @@ export function ReplaySyncVerdict({
|
||||
saved ? `Saved: ${saved.verified ? "perfectly synced" : "not perfect"}${saved.at ? ` · ${saved.at.slice(0, 16).replace("T", " ")}` : ""}` : "Not triaged yet"
|
||||
)
|
||||
const [busy, setBusy] = useState(false)
|
||||
const markDirty = () => setStatus("Unsaved changes")
|
||||
|
||||
const nextJob = () => {
|
||||
const queue = new URLSearchParams(window.location.search).get("queue")?.split(",").map((x) => x.trim()).filter(Boolean) ?? []
|
||||
@@ -654,13 +655,13 @@ export function ReplaySyncVerdict({
|
||||
<div className="mx-4 mt-2 rounded-lg border bg-card px-3 py-2 space-y-2" data-testid="replay-sync-verdict">
|
||||
<div className="flex flex-wrap items-center gap-2">
|
||||
<span className="text-xs text-muted-foreground mr-1">Reference set:</span>
|
||||
<button className={pill(choice === "synced", "good")} onClick={() => setChoice("synced")}>Perfectly synced</button>
|
||||
<button className={pill(choice === "not", "bad")} onClick={() => setChoice("not")}>Not perfect</button>
|
||||
<button className={pill(choice === "synced", "good")} onClick={() => { setChoice("synced"); markDirty() }}>Perfectly synced</button>
|
||||
<button className={pill(choice === "not", "bad")} onClick={() => { setChoice("not"); markDirty() }}>Not perfect</button>
|
||||
<input
|
||||
className="flex-1 min-w-[12rem] rounded border bg-background px-2 py-1 text-sm"
|
||||
placeholder="Notes (optional)"
|
||||
value={notes}
|
||||
onChange={(e) => setNotes(e.target.value)}
|
||||
onChange={(e) => { setNotes(e.target.value); markDirty() }}
|
||||
/>
|
||||
<button className="px-3 py-1 rounded text-sm font-medium border hover:bg-muted" disabled={!choice || busy} onClick={() => save(false)}>Save</button>
|
||||
<button className="px-3 py-1 rounded text-sm font-medium bg-primary text-primary-foreground disabled:opacity-40" disabled={!choice || busy} onClick={() => save(true)}>Save & next job →</button>
|
||||
@@ -673,7 +674,7 @@ export function ReplaySyncVerdict({
|
||||
<input
|
||||
type="checkbox"
|
||||
checked={reasons.includes(r)}
|
||||
onChange={(e) => setReasons(e.target.checked ? [...reasons, r] : reasons.filter((x) => x !== r))}
|
||||
onChange={(e) => { setReasons(e.target.checked ? [...reasons, r] : reasons.filter((x) => x !== r)); markDirty() }}
|
||||
/>
|
||||
{r}
|
||||
</label>
|
||||
|
||||
@@ -38,7 +38,18 @@ describe('ReplaySyncVerdict (replay triage for the timing reference set)', () =>
|
||||
it('shows the saved verdict and keeps Save disabled until a choice exists', () => {
|
||||
render(<ReplaySyncVerdict jobId="b2" saved={{ verified: true, at: '2026-11-04T10:00:00+00:00' }} />)
|
||||
expect(screen.getByTestId('replay-sync-status')).toHaveTextContent('Saved: perfectly synced')
|
||||
})
|
||||
|
||||
it('flags an unsaved change until it is saved', async () => {
|
||||
render(<ReplaySyncVerdict jobId="b2" saved={{ verified: true }} />)
|
||||
await userEvent.click(screen.getByRole('button', { name: 'Not perfect' }))
|
||||
expect(screen.getByTestId('replay-sync-status')).toHaveTextContent('Unsaved changes')
|
||||
await userEvent.click(screen.getByRole('button', { name: 'Save' }))
|
||||
expect(screen.getByTestId('replay-sync-status')).toHaveTextContent('Saved: not perfect')
|
||||
})
|
||||
|
||||
it('keeps Save disabled until a choice exists', () => {
|
||||
render(<ReplaySyncVerdict jobId="a1" saved={null} />)
|
||||
expect(screen.getAllByRole('button', { name: 'Save' })[1]).toBeDisabled()
|
||||
expect(screen.getByRole('button', { name: 'Save' })).toBeDisabled()
|
||||
})
|
||||
})
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
[tool.poetry]
|
||||
name = "karaoke-gen"
|
||||
version = "0.291.2"
|
||||
version = "0.292.0"
|
||||
description = "Generate karaoke videos with synchronized lyrics. Handles the entire process from downloading audio and lyrics to creating the final video with title screens."
|
||||
authors = ["Andrew Beveridge <andrew@beveridge.uk>"]
|
||||
license = "MIT"
|
||||
|
||||
Reference in new issue
Block a user