feat: requests board picks the visitor's language + header language switcher (#1198)

## Summary
Follow-up to #1193. `requests.nomadkaraoke.com` always served the
English board (the old redirect was also hard-coded to `/en/requests`).

- **Worker (`requests-host`, already deployed):** `/` serves
`/{locale}/requests/`. The locale comes from the `nk_requests_locale`
cookie, else `Accept-Language` (primary-subtag match like gen's
`LocaleRedirect`, so `pt-BR` → `pt` and `nn` → `nb`), else `en`.
`/{locale}/` (e.g. `/es/`) forces a language. Responses send `Vary:
Accept-Language, Cookie`.
- **Board header:** gen's `LanguageSwitcher` sits top-right. On the
vanity host it sets the cookie and reloads `/`, so the copyable URL
stays bare. On gen it behaves as before (`router.replace` to
`/{locale}/requests`).
- **`LanguageSwitcher`:** new optional `onSelectLocale` prop that
replaces the default navigation.

## Testing
- Worker: `node --test infrastructure/cloudflare/requests-host/`, 10
pass. This includes a check that the Worker's locale list matches
`frontend/i18n/routing.ts`.
- New `components/__tests__/LanguageSwitcher.test.tsx` (2 tests); the
703 component tests pass.
- Live checks against the deployed Worker: `es`, `ja`, `pt-BR`, `en-US`
each get the translated board, and the cookie beats `Accept-Language`.
- Mobile (390px) screenshot of a local build: the switcher shows as a
compact flag top-right and the dropdown fits the screen.
- Prod E2E spec extended with a browser-language check and a switcher
round-trip. It will run after deploy.

Local CodeRabbit review: no findings.

@coderabbitai ignore

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_016FYpoNVXzJzqKFaowqpwxr

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Andrew Beveridge ☄️andClaude Opus 5.5 authored and GitHub committed 2026-10-19 16:15:08 -04:00
1 parent 37b4f5126a
commit 867617626a
38 files changed
+276 -40

No files matched your search

+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "خطأ في إنشاء بيانات الشكل الموجي: {error}",
"waveformNoAudio": "لا يوجد صوت متاح للشكل الموجي",
"sessionSaveError": "بيانات التصحيح مطلوبة",
"invalidIsDuetFlag": "يجب أن يكون is_duet قيمة منطقية (true أو false)"
"invalidIsDuetFlag": "يجب أن يكون is_duet قيمة منطقية (true أو false)",
"previewMissingTimings": "يحتوي السطر \"{line}\" على كلمة بلا توقيت. قم بمزامنة هذا السطر، ثم حاول المعاينة مرة أخرى."
},
"audioSearch": {
"notEnabled": "البحث الصوتي غير مفعل لهذا المستأجر",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Error en generar les dades de la forma d'ona: {error}",
"waveformNoAudio": "No hi ha àudio disponible per a la forma d'ona",
"sessionSaveError": "Es requereixen dades de correcció",
"invalidIsDuetFlag": "is_duet ha de ser un booleà (cert o fals)"
"invalidIsDuetFlag": "is_duet ha de ser un booleà (cert o fals)",
"previewMissingTimings": "La línia \"{line}\" té una paraula sense temporització. Sincronitza aquesta línia i torna a provar la previsualització."
},
"audioSearch": {
"notEnabled": "La cerca d'àudio no està activada per a aquest tenant",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Chyba při generování dat křivky: {error}",
"waveformNoAudio": "Pro křivku není k dispozici žádný zvuk",
"sessionSaveError": "Jsou vyžadována data oprav",
"invalidIsDuetFlag": "is_duet musí být typu boolean (true nebo false)"
"invalidIsDuetFlag": "is_duet musí být typu boolean (true nebo false)",
"previewMissingTimings": "Řádek „{line}“ obsahuje slovo bez časování. Synchronizuj tento řádek a zkus náhled znovu."
},
"audioSearch": {
"notEnabled": "Vyhledávání zvuku není pro tohoto tenanta povoleno",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Fejl ved generering af bølgeformsdata: {error}",
"waveformNoAudio": "Ingen lyd tilgængelig til bølgeform",
"sessionSaveError": "Rettelsesdata er påkrævet",
"invalidIsDuetFlag": "is_duet skal være en boolsk værdi (sand eller falsk)"
"invalidIsDuetFlag": "is_duet skal være en boolsk værdi (sand eller falsk)",
"previewMissingTimings": "Linjen \"{line}\" har et ord uden timing. Synkroniser den linje, og prøv derefter forhåndsvisningen igen."
},
"audioSearch": {
"notEnabled": "Lydsøgning er ikke aktiveret for denne lejer",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Σφάλμα κατά τη δημιουργία δεδομένων κυματομορφής: {error}",
"waveformNoAudio": "Δεν υπάρχει διαθέσιμος ήχος για την κυματομορφή",
"sessionSaveError": "Απαιτούνται δεδομένα διόρθωσης",
"invalidIsDuetFlag": "Το is_duet πρέπει να είναι boolean (true ή false)"
"invalidIsDuetFlag": "Το is_duet πρέπει να είναι boolean (true ή false)",
"previewMissingTimings": "Η γραμμή «{line}» περιέχει μια λέξη χωρίς συγχρονισμό. Συγχρόνισε αυτή τη γραμμή και δοκίμασε ξανά την προεπισκόπηση."
},
"audioSearch": {
"notEnabled": "Η αναζήτηση ήχου δεν είναι ενεργοποιημένη για αυτόν τον μισθωτή",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Virhe luotaessa aaltomuotodataa: {error}",
"waveformNoAudio": "Ääntä ei ole saatavilla aaltomuotoa varten",
"sessionSaveError": "Korjaustiedot vaaditaan",
"invalidIsDuetFlag": "is_duet täytyy olla totuusarvo (true tai false)"
"invalidIsDuetFlag": "is_duet täytyy olla totuusarvo (true tai false)",
"previewMissingTimings": "Rivillä \"{line}\" on sana, jolla ei ole ajoitusta. Synkronoi kyseinen rivi ja yritä esikatselua uudelleen."
},
"audioSearch": {
"notEnabled": "Äänihaku ei ole käytössä tälle asiakkaalle",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Erreur lors de la génération des données de forme d'onde : {error}",
"waveformNoAudio": "Aucun audio disponible pour la forme d'onde",
"sessionSaveError": "Les données de correction sont requises",
"invalidIsDuetFlag": "is_duet doit être un booléen (true ou false)"
"invalidIsDuetFlag": "is_duet doit être un booléen (true ou false)",
"previewMissingTimings": "La ligne « {line} » contient un mot sans synchronisation. Synchronise cette ligne, puis réessaie l'aperçu."
},
"audioSearch": {
"notEnabled": "La recherche audio n'est pas activée pour ce compte",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "שגיאה ביצירת נתוני גל הקול: {error}",
"waveformNoAudio": "אין אודיו זמין עבור גל הקול",
"sessionSaveError": "נדרשים נתוני תיקון",
"invalidIsDuetFlag": "is_duet חייב להיות ערך בוליאני (true או false)"
"invalidIsDuetFlag": "is_duet חייב להיות ערך בוליאני (true או false)",
"previewMissingTimings": "בשורה \"{line}\" יש מילה ללא תזמון. סנכרנו את השורה הזו ונסו שוב את התצוגה המקדימה."
},
"audioSearch": {
"notEnabled": "חיפוש אודיו אינו מופעל עבור חשבון זה",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "वेवफ़ॉर्म डेटा जनरेट करने में त्रुटि: {error}",
"waveformNoAudio": "वेवफ़ॉर्म के लिए कोई ऑडियो उपलब्ध नहीं है",
"sessionSaveError": "करेक्शन डेटा आवश्यक है",
"invalidIsDuetFlag": "is_duet एक boolean (true या false) होना चाहिए"
"invalidIsDuetFlag": "is_duet एक boolean (true या false) होना चाहिए",
"previewMissingTimings": "पंक्ति \"{line}\" में एक ऐसा शब्द है जिसकी टाइमिंग नहीं है। उस पंक्ति को सिंक करो, फिर प्रीव्यू दोबारा आज़माओ।"
},
"audioSearch": {
"notEnabled": "इस टेनेंट के लिए ऑडियो सर्च सक्षम नहीं है",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Pogreška pri generiranju podataka valnog oblika: {error}",
"waveformNoAudio": "Nema dostupnog zvuka za valni oblik",
"sessionSaveError": "Podaci o ispravcima su obavezni",
"invalidIsDuetFlag": "is_duet mora biti boolean (true ili false)"
"invalidIsDuetFlag": "is_duet mora biti boolean (true ili false)",
"previewMissingTimings": "Redak \"{line}\" sadrži riječ bez vremenskog označavanja. Sinkroniziraj taj redak, a zatim ponovno pokušaj pregled."
},
"audioSearch": {
"notEnabled": "Pretraživanje zvuka nije omogućeno za ovog zakupca",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Hiba a hullámforma adatok generálásakor: {error}",
"waveformNoAudio": "Nincs elérhető hang a hullámformához",
"sessionSaveError": "Javítási adatok szükségesek",
"invalidIsDuetFlag": "Az is_duet értékének logikai (boolean) típusúnak kell lennie (true vagy false)"
"invalidIsDuetFlag": "Az is_duet értékének logikai (boolean) típusúnak kell lennie (true vagy false)",
"previewMissingTimings": "A(z) „{line}” sorban van egy időzítés nélküli szó. Szinkronizáld azt a sort, majd próbáld újra az előnézetet."
},
"audioSearch": {
"notEnabled": "A hangkeresés nincs engedélyezve ehhez a bérlőhöz",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Kesalahan saat membuat data bentuk gelombang: {error}",
"waveformNoAudio": "Tidak ada audio yang tersedia untuk bentuk gelombang",
"sessionSaveError": "Data koreksi diperlukan",
"invalidIsDuetFlag": "is_duet harus berupa boolean (true atau false)"
"invalidIsDuetFlag": "is_duet harus berupa boolean (true atau false)",
"previewMissingTimings": "Baris \"{line}\" memiliki kata tanpa waktu. Sinkronkan baris tersebut, lalu coba pratinjau lagi."
},
"audioSearch": {
"notEnabled": "Pencarian audio tidak diaktifkan untuk tenant ini",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Errore durante la generazione dei dati della forma d'onda: {error}",
"waveformNoAudio": "Nessun audio disponibile per la forma d'onda",
"sessionSaveError": "I dati di correzione sono richiesti",
"invalidIsDuetFlag": "is_duet deve essere un booleano (true o false)"
"invalidIsDuetFlag": "is_duet deve essere un booleano (true o false)",
"previewMissingTimings": "La riga \"{line}\" contiene una parola senza tempo. Sincronizza quella riga, poi riprova l'anteprima."
},
"audioSearch": {
"notEnabled": "La ricerca audio non è abilitata per questo tenant",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "波形データの生成中にエラーが発生しました: {error}",
"waveformNoAudio": "波形用のオーディオがありません",
"sessionSaveError": "修正データが必要です",
"invalidIsDuetFlag": "is_duet はブール値 (true または false) である必要があります"
"invalidIsDuetFlag": "is_duet はブール値 (true または false) である必要があります",
"previewMissingTimings": "「{line}」の行にタイミングが設定されていない単語があります。その行を同期してから、もう一度プレビューしてください。"
},
"audioSearch": {
"notEnabled": "このテナントではオーディオ検索が有効になっていません",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "파형 데이터 생성 중 오류 발생: {error}",
"waveformNoAudio": "파형에 사용할 오디오가 없습니다",
"sessionSaveError": "수정 데이터가 필요합니다",
"invalidIsDuetFlag": "is_duet은 불리언(true 또는 false)이어야 합니다."
"invalidIsDuetFlag": "is_duet은 불리언(true 또는 false)이어야 합니다.",
"previewMissingTimings": "\"{line}\" 줄에 타이밍이 없는 단어가 있습니다. 해당 줄을 동기화한 후 미리보기를 다시 시도해 주세요."
},
"audioSearch": {
"notEnabled": "이 테넌트에서는 오디오 검색이 활성화되어 있지 않습니다",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Ralat menjana data bentuk gelombang: {error}",
"waveformNoAudio": "Tiada audio tersedia untuk bentuk gelombang",
"sessionSaveError": "Data pembetulan diperlukan",
"invalidIsDuetFlag": "is_duet mestilah boolean (benar atau salah)"
"invalidIsDuetFlag": "is_duet mestilah boolean (benar atau salah)",
"previewMissingTimings": "Baris \"{line}\" mempunyai perkataan tanpa pemasaan. Segerakkan baris itu, kemudian cuba pratonton semula."
},
"audioSearch": {
"notEnabled": "Carian audio tidak didayakan untuk penyewa ini",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Feil ved generering av bølgeformdata: {error}",
"waveformNoAudio": "Ingen lyd tilgjengelig for bølgeform",
"sessionSaveError": "Korreksjonsdata er påkrevd",
"invalidIsDuetFlag": "is_duet må være en boolean (true eller false)"
"invalidIsDuetFlag": "is_duet må være en boolean (true eller false)",
"previewMissingTimings": "Linjen «{line}» har et ord uten timing. Synkroniser den linjen, og prøv forhåndsvisningen på nytt."
},
"audioSearch": {
"notEnabled": "Lydsøk er ikke aktivert for denne kontoen",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Fout bij het genereren van golfvormgegevens: {error}",
"waveformNoAudio": "Geen audio beschikbaar voor golfvorm",
"sessionSaveError": "Correctiegegevens zijn vereist",
"invalidIsDuetFlag": "is_duet moet een boolean (true of false) zijn"
"invalidIsDuetFlag": "is_duet moet een boolean (true of false) zijn",
"previewMissingTimings": "De regel \"{line}\" bevat een woord zonder timing. Synchroniseer die regel en probeer de preview opnieuw."
},
"audioSearch": {
"notEnabled": "Audio zoeken is niet ingeschakeld voor deze tenant",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Błąd podczas generowania danych fali dźwiękowej: {error}",
"waveformNoAudio": "Brak dostępnego dźwięku dla fali dźwiękowej",
"sessionSaveError": "Dane poprawek są wymagane",
"invalidIsDuetFlag": "is_duet musi być wartością logiczną (true lub false)"
"invalidIsDuetFlag": "is_duet musi być wartością logiczną (true lub false)",
"previewMissingTimings": "Wiersz „{line}” zawiera słowo bez synchronizacji. Zsynchronizuj ten wiersz, a następnie spróbuj ponownie wyświetlić podgląd."
},
"audioSearch": {
"notEnabled": "Wyszukiwanie audio nie jest włączone dla tego konta",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Erro ao gerar dados da forma de onda: {error}",
"waveformNoAudio": "Nenhum áudio disponível para a forma de onda",
"sessionSaveError": "Dados de correção são obrigatórios",
"invalidIsDuetFlag": "is_duet deve ser um booleano (verdadeiro ou falso)"
"invalidIsDuetFlag": "is_duet deve ser um booleano (verdadeiro ou falso)",
"previewMissingTimings": "A linha \"{line}\" tem uma palavra sem tempo definido. Sincronize essa linha e tente a pré-visualização novamente."
},
"audioSearch": {
"notEnabled": "A pesquisa de áudio não está ativada para este locatário",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Eroare la generarea datelor formei de undă: {error}",
"waveformNoAudio": "Niciun fișier audio disponibil pentru forma de undă",
"sessionSaveError": "Datele de corecție sunt obligatorii",
"invalidIsDuetFlag": "is_duet trebuie să fie un boolean (true sau false)"
"invalidIsDuetFlag": "is_duet trebuie să fie un boolean (true sau false)",
"previewMissingTimings": "Rândul „{line}” conține un cuvânt fără sincronizare. Sincronizează acel rând, apoi încearcă din nou previzualizarea."
},
"audioSearch": {
"notEnabled": "Căutarea audio nu este activată pentru acest tenant",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Ошибка при генерации данных осциллограммы: {error}",
"waveformNoAudio": "Нет аудио для осциллограммы",
"sessionSaveError": "Требуются данные исправлений",
"invalidIsDuetFlag": "is_duet должно быть булевым значением (true или false)"
"invalidIsDuetFlag": "is_duet должно быть булевым значением (true или false)",
"previewMissingTimings": "В строке «{line}» есть слово без тайминга. Синхронизируй эту строку и попробуй предпросмотр ещё раз."
},
"audioSearch": {
"notEnabled": "Поиск аудио не включен для этого аккаунта",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Chyba pri generovaní údajov o zvukovej vlne: {error}",
"waveformNoAudio": "Nie je k dispozícii žiadny zvuk pre zvukovú vlnu",
"sessionSaveError": "Vyžadujú sa údaje o opravách",
"invalidIsDuetFlag": "is_duet musí byť boolean (true alebo false)"
"invalidIsDuetFlag": "is_duet musí byť boolean (true alebo false)",
"previewMissingTimings": "Riadok „{line}“ obsahuje slovo bez časovania. Synchronizuj tento riadok a skús náhľad znova."
},
"audioSearch": {
"notEnabled": "Vyhľadávanie zvuku nie je pre tohto nájomcu povolené",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Fel vid generering av vågformsdata: {error}",
"waveformNoAudio": "Inget ljud tillgängligt för vågform",
"sessionSaveError": "Korrigeringsdata krävs",
"invalidIsDuetFlag": "is_duet måste vara ett booleskt värde (true eller false)"
"invalidIsDuetFlag": "is_duet måste vara ett booleskt värde (true eller false)",
"previewMissingTimings": "Raden \"{line}\" har ett ord utan timing. Synka den raden och försök sedan förhandsgranska igen."
},
"audioSearch": {
"notEnabled": "Ljudsökning är inte aktiverad för denna klient",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "เกิดข้อผิดพลาดในการสร้างข้อมูลรูปคลื่นเสียง: {error}",
"waveformNoAudio": "ไม่มีเสียงสำหรับรูปคลื่นเสียง",
"sessionSaveError": "จำเป็นต้องมีข้อมูลการแก้ไข",
"invalidIsDuetFlag": "is_duet ต้องเป็นค่าบูลีน (true หรือ false)"
"invalidIsDuetFlag": "is_duet ต้องเป็นค่าบูลีน (true หรือ false)",
"previewMissingTimings": "บรรทัด \"{line}\" มีคำที่ไม่มีการตั้งเวลา ซิงค์บรรทัดนั้นแล้วลองแสดงตัวอย่างอีกครั้ง"
},
"audioSearch": {
"notEnabled": "ไม่ได้เปิดใช้งานการค้นหาเสียงสำหรับผู้เช่ารายนี้",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Error sa paggawa ng waveform data: {error}",
"waveformNoAudio": "Walang available na audio para sa waveform",
"sessionSaveError": "Kailangan ng correction data",
"invalidIsDuetFlag": "Ang is_duet ay dapat isang boolean (true o false)"
"invalidIsDuetFlag": "Ang is_duet ay dapat isang boolean (true o false)",
"previewMissingTimings": "Ang linyang \"{line}\" ay may salitang walang timing. I-sync ang linyang iyon, saka subukang muli ang preview."
},
"audioSearch": {
"notEnabled": "Hindi naka-enable ang audio search para sa tenant na ito",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Dalga formu verisi oluşturma hatası: {error}",
"waveformNoAudio": "Dalga formu için ses mevcut değil",
"sessionSaveError": "Düzeltme verisi gereklidir",
"invalidIsDuetFlag": "is_duet bir boolean (true veya false) olmalı"
"invalidIsDuetFlag": "is_duet bir boolean (true veya false) olmalı",
"previewMissingTimings": "\"{line}\" satırında zamanlaması olmayan bir kelime var. O satırı senkronize et, ardından önizlemeyi tekrar dene."
},
"audioSearch": {
"notEnabled": "Bu kiracı için ses arama etkin değil",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Помилка генерації даних хвильової форми: {error}",
"waveformNoAudio": "Немає аудіо для хвильової форми",
"sessionSaveError": "Потрібні дані виправлень",
"invalidIsDuetFlag": "is_duet має бути булевим значенням (true або false)"
"invalidIsDuetFlag": "is_duet має бути булевим значенням (true або false)",
"previewMissingTimings": "У рядку «{line}» є слово без таймінгу. Синхронізуй цей рядок і спробуй попередній перегляд ще раз."
},
"audioSearch": {
"notEnabled": "Пошук аудіо не ввімкнено для цього орендаря",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "Lỗi khi tạo dữ liệu dạng sóng: {error}",
"waveformNoAudio": "Không có âm thanh cho dạng sóng",
"sessionSaveError": "Yêu cầu dữ liệu chỉnh sửa",
"invalidIsDuetFlag": "is_duet phải là kiểu boolean (true hoặc false)"
"invalidIsDuetFlag": "is_duet phải là kiểu boolean (true hoặc false)",
"previewMissingTimings": "Dòng \"{line}\" có một từ chưa được căn thời gian. Hãy đồng bộ dòng đó rồi thử xem trước lại."
},
"audioSearch": {
"notEnabled": "Tìm kiếm âm thanh không được bật cho tenant này",
+2 -1
View File
@@ -81,7 +81,8 @@
"waveformGenerationError": "生成波形数据时出错:{error}",
"waveformNoAudio": "没有可生成波形的音频",
"sessionSaveError": "需要校对数据",
"invalidIsDuetFlag": "is_duet 必须是布尔值(true 或 false)"
"invalidIsDuetFlag": "is_duet 必须是布尔值(true 或 false)",
"previewMissingTimings": "“{line}”这一行有一个没有时间轴的单词。请先同步该行,然后再次尝试预览。"
},
"audioSearch": {
"notEnabled": "此租户未启用音频搜索",
@@ -15,12 +15,17 @@ The public voting board is a static route in the gen Next.js build
The Worker:
- `/` → fetches gen `/en/requests/` and returns it (query string kept, e.g. `utm_*`).
- `/` → fetches gen `/{locale}/requests/` and returns it (query string kept, e.g. `utm_*`).
Locale = the `nk_requests_locale` cookie (set by the board's language switcher on this host),
else the browser's `Accept-Language` (same primary-subtag matching as gen's `LocaleRedirect`),
else `en`. Response carries `Vary: Accept-Language, Cookie`.
- `/{locale}` or `/{locale}/` (e.g. `/es/`) → that language's board, for explicit links.
- paths with a file extension (`/_next/*`, fonts, icons, `sw.js`, RSC `.txt`) → proxied from gen.
- any other page path → 302 to the same path on gen, so the app never runs on this origin.
The frontend treats `requests` as a non-tenant subdomain (`frontend/lib/edge/nonTenantSubdomains.ts`,
`backend/middleware/tenant.py`), and the board's "Make it yourself" button leaves for
`backend/middleware/tenant.py`), the board header's language switcher sets the cookie and reloads `/` on this host (so the
shareable URL stays bare), and the board's "Make it yourself" button leaves for
`gen.nomadkaraoke.com/app` when on this host. Board sign-in magic links still land on gen
(`/en/auth/verify` → `/requests`), so a user who signs in ends up on the gen copy of the board.
+17 -1
View File
@@ -18,10 +18,19 @@ import { api, getAccessToken } from '@/lib/api';
import type { CommunityCheckResponse } from '@/lib/api';
import { useAuth } from '@/lib/auth';
import { CommunityVersionBanner } from '@/components/job/CommunityVersionBanner';
import LanguageSwitcher from '@/components/LanguageSwitcher';
import type { BoardResponse, SongRequestPublic } from '@/lib/types';
const BOARD_PURPOSE = 'requests_board';
const REQUESTS_HOST = 'requests.nomadkaraoke.com';
// Read by the requests-host Worker (infrastructure/cloudflare/requests-host) to pick the
// board language at "/", so the shareable URL stays bare after switching language.
const REQUESTS_LOCALE_COOKIE = 'nk_requests_locale';
function selectLocaleOnRequestsHost(code: string) {
document.cookie = `${REQUESTS_LOCALE_COOKIE}=${code}; path=/; max-age=31536000; secure; samesite=lax`;
window.location.assign('/');
}
export function RequestsBoardClient() {
const t = useTranslations('requests');
@@ -49,6 +58,10 @@ export function RequestsBoardClient() {
const [pendingVoteId, setPendingVoteId] = useState<string | null>(null);
const isSignedIn = !!user;
const [onRequestsHost, setOnRequestsHost] = useState(false);
useEffect(() => {
setOnRequestsHost(window.location.hostname === REQUESTS_HOST);
}, []);
// Guards against an older refresh resolving after a newer one and clobbering state
// (refresh can fire concurrently from hydration + submit + vote).
@@ -182,7 +195,10 @@ export function RequestsBoardClient() {
<div className="min-h-screen" style={{ background: 'var(--bg)', color: 'var(--text)' }}>
<div className="max-w-2xl mx-auto px-4 py-8 space-y-8">
{/* Header */}
<header className="text-center space-y-3">
<header className="relative text-center space-y-3">
<div className="absolute end-0 top-0">
<LanguageSwitcher onSelectLocale={onRequestsHost ? selectLocaleOnRequestsHost : undefined} />
</div>
<div className="flex justify-center">
<div className="p-3 rounded-full" style={{ backgroundColor: 'rgba(168, 85, 247, 0.1)' }}>
<Music className="w-8 h-8" style={{ color: 'var(--accent)' }} />
+12 -1
View File
@@ -40,7 +40,14 @@ const LOCALE_INFO: { code: string; native: string; english: string; flag: string
{ code: 'ca', native: 'Catal\u00e0', english: 'Catalan', flag: '\u{1F3F4}' },
];
export default function LanguageSwitcher({ showLabel }: { showLabel?: boolean } = {}) {
export default function LanguageSwitcher({
showLabel,
onSelectLocale,
}: {
showLabel?: boolean;
/** Replaces the default in-app locale navigation (e.g. on hosts that serve a single page). */
onSelectLocale?: (code: string) => void;
} = {}) {
const locale = useLocale();
const router = useRouter();
const pathname = usePathname();
@@ -75,6 +82,10 @@ export default function LanguageSwitcher({ showLabel }: { showLabel?: boolean }
function handleSelect(code: string) {
setOpen(false);
try { localStorage.setItem('locale', code); } catch {}
if (onSelectLocale) {
onSelectLocale(code);
return;
}
router.replace(pathname, { locale: code });
}
@@ -0,0 +1,41 @@
/**
* @jest-environment jsdom
*/
import React from 'react'
import { render, screen, fireEvent } from '@testing-library/react'
import LanguageSwitcher from '../LanguageSwitcher'
const replaceMock = jest.fn()
jest.mock('@/i18n/routing', () => ({
useRouter: () => ({ replace: replaceMock }),
usePathname: () => '/requests',
routing: { locales: ['en', 'es', 'de'] },
}))
function pick(language: RegExp) {
fireEvent.click(screen.getByRole('button', { expanded: false }))
fireEvent.click(screen.getByRole('button', { name: language }))
}
describe('LanguageSwitcher', () => {
beforeEach(() => {
replaceMock.mockClear()
localStorage.clear()
})
it('navigates to the same path in the chosen locale by default', () => {
render(<LanguageSwitcher />)
pick(/Deutsch/)
expect(replaceMock).toHaveBeenCalledWith('/requests', { locale: 'de' })
expect(localStorage.getItem('locale')).toBe('de')
})
it('hands the choice to onSelectLocale instead of routing when provided', () => {
const onSelectLocale = jest.fn()
render(<LanguageSwitcher onSelectLocale={onSelectLocale} />)
pick(/Espa/)
expect(onSelectLocale).toHaveBeenCalledWith('es')
expect(replaceMock).not.toHaveBeenCalled()
expect(localStorage.getItem('locale')).toBe('es')
})
})
@@ -45,6 +45,32 @@ test.describe('requests.nomadkaraoke.com vanity host', () => {
expect(tenantHeaders).toEqual([]);
});
test('picks the board language from the browser', async ({ browser }) => {
const context = await browser.newContext({ locale: 'es-ES' });
const page = await context.newPage();
await page.goto(`${REQUESTS_ORIGIN}/`);
await expect(page.getByRole('heading', { level: 1 })).toContainText('Vota', { timeout: 30_000 });
expect(new URL(page.url()).pathname).toBe('/');
await context.close();
});
test('language switcher keeps the bare URL and remembers the choice', async ({ browser }) => {
const context = await browser.newContext({ locale: 'en-US' });
const page = await context.newPage();
await page.goto(`${REQUESTS_ORIGIN}/`);
await expect(page.getByRole('heading', { level: 1 })).toContainText('Vote', { timeout: 30_000 });
await page.getByRole('button', { expanded: false }).filter({ hasText: 'English' }).first().click();
await page.getByRole('button', { name: /Deutsch/ }).click();
await expect(page.getByRole('heading', { level: 1 })).toContainText('Stimme', { timeout: 30_000 });
expect(new URL(page.url()).pathname).toBe('/');
// A fresh visit to the bare URL stays German (cookie read by the requests-host Worker).
await page.goto(`${REQUESTS_ORIGIN}/`);
await expect(page.getByRole('heading', { level: 1 })).toContainText('Stimme', { timeout: 30_000 });
await context.close();
});
test('other page paths redirect to gen', async ({ request }) => {
const response = await request.get(`${REQUESTS_ORIGIN}/en/app/`, { maxRedirects: 0 });
expect([301, 302]).toContain(response.status());
@@ -1,12 +1,14 @@
/**
* requests-host: serves the song-request voting board ON requests.nomadkaraoke.com.
*
* The board is a static page in the gen Pages build (gen.nomadkaraoke.com/en/requests/).
* The board is a static page in the gen Pages build (gen.nomadkaraoke.com/{locale}/requests/).
* Before this Worker the vanity host 302-redirected there, so the address bar showed the
* long gen URL and the short link couldn't be copied back out on mobile (Andrew pastes it
* into YouTube comment replies). Now the short URL stays put:
*
* / -> gen /en/requests/ fetched and returned as-is (query kept)
* / -> gen /{locale}/requests/ (query kept); locale = the board's
* language-switcher cookie, else Accept-Language, else en
* /{locale} or /{locale}/ -> gen /{locale}/requests/ (explicit language, e.g. /es/)
* paths with an extension -> proxied from gen (/_next/* chunks, fonts, icons, sw.js, ...)
* any other page path -> 302 to the same path on gen (the app lives there)
*
@@ -19,19 +21,74 @@
*/
export const GEN_ORIGIN = "https://gen.nomadkaraoke.com"
const BOARD_PATH = "/en/requests/"
// Mirror of frontend/i18n/routing.ts locales.
export const LOCALES = [
"en", "es", "de", "pt", "fr", "ja", "ko", "zh", "it", "nl",
"pl", "tr", "ru", "th", "id", "vi", "tl", "hi", "ar", "sv",
"nb", "da", "fi", "cs", "ro", "hu", "el", "he", "ms", "uk",
"hr", "sk", "ca",
]
const DEFAULT_LOCALE = "en"
// Set by the board's language switcher on this host (frontend/app/[locale]/requests/client.tsx).
export const LOCALE_COOKIE = "nk_requests_locale"
export function hasExtension(pathname) {
const last = pathname.slice(pathname.lastIndexOf("/") + 1)
return last.includes(".")
}
/**
* First supported language in Accept-Language, by q-weight then order. Matches on the
* primary subtag like the frontend's LocaleRedirect ("pt-BR" -> "pt"); "no"/"nn" -> "nb".
*/
export function pickLocale(acceptLanguage) {
const prefs = (acceptLanguage || "")
.split(",")
.map((part, index) => {
const [tag, ...params] = part.trim().split(";")
const q = params.map((p) => p.trim()).find((p) => p.startsWith("q="))
return { tag: tag.toLowerCase(), q: q ? Number(q.slice(2)) || 0 : 1, index }
})
.filter((p) => p.tag && p.q > 0)
.sort((a, b) => b.q - a.q || a.index - b.index)
for (const { tag } of prefs) {
let prefix = tag.split("-")[0]
if (prefix === "no" || prefix === "nn") prefix = "nb"
if (LOCALES.includes(prefix)) return prefix
}
return DEFAULT_LOCALE
}
export function cookieLocale(cookieHeader) {
for (const part of (cookieHeader || "").split(";")) {
const [name, value] = part.trim().split("=")
if (name === LOCALE_COOKIE && LOCALES.includes(value)) return value
}
return null
}
function serveBoard(request, locale, search) {
return fetch(new Request(`${GEN_ORIGIN}/${locale}/requests/${search}`, request)).then((res) => {
const out = new Response(res.body, res)
out.headers.append("Vary", "Accept-Language, Cookie")
return out
})
}
export default {
async fetch(request) {
const url = new URL(request.url)
if (url.pathname === "/") {
return fetch(new Request(`${GEN_ORIGIN}${BOARD_PATH}${url.search}`, request))
const locale =
cookieLocale(request.headers.get("cookie")) || pickLocale(request.headers.get("accept-language"))
return serveBoard(request, locale, url.search)
}
const explicit = url.pathname.match(/^\/([a-z]{2})\/?$/)
if (explicit && LOCALES.includes(explicit[1])) {
return serveBoard(request, explicit[1], url.search)
}
if (hasExtension(url.pathname)) {
@@ -1,7 +1,8 @@
// Run: node --test infrastructure/cloudflare/requests-host/
import { test, beforeEach } from "node:test"
import assert from "node:assert/strict"
import worker, { hasExtension } from "./worker.js"
import { readFileSync } from "node:fs"
import worker, { hasExtension, pickLocale, cookieLocale, LOCALES } from "./worker.js"
let fetched
beforeEach(() => {
@@ -15,9 +16,58 @@ beforeEach(() => {
test("/ serves the board page from gen, keeping the query string", async () => {
const res = await worker.fetch(new Request("https://requests.nomadkaraoke.com/?utm_source=youtube"))
assert.equal(res.status, 200)
assert.match(res.headers.get("vary"), /Accept-Language/)
assert.deepEqual(fetched, ["https://gen.nomadkaraoke.com/en/requests/?utm_source=youtube"])
})
test("/ picks the board language from Accept-Language", async () => {
await worker.fetch(new Request("https://requests.nomadkaraoke.com/", {
headers: { "accept-language": "es-MX,es;q=0.9,en;q=0.8" },
}))
assert.deepEqual(fetched, ["https://gen.nomadkaraoke.com/es/requests/"])
})
test("/ prefers the language-switcher cookie over Accept-Language", async () => {
await worker.fetch(new Request("https://requests.nomadkaraoke.com/", {
headers: { "accept-language": "es", cookie: "a=b; nk_requests_locale=ja" },
}))
assert.deepEqual(fetched, ["https://gen.nomadkaraoke.com/ja/requests/"])
})
test("cookieLocale ignores unknown values", () => {
assert.equal(cookieLocale("nk_requests_locale=xx"), null)
assert.equal(cookieLocale("nk_requests_locale=../app"), null)
assert.equal(cookieLocale(null), null)
})
test("/{locale}/ forces a language; unknown 2-letter paths go to gen", async () => {
await worker.fetch(new Request("https://requests.nomadkaraoke.com/de/?utm_source=x", {
headers: { "accept-language": "fr" },
}))
await worker.fetch(new Request("https://requests.nomadkaraoke.com/ja"))
const res = await worker.fetch(new Request("https://requests.nomadkaraoke.com/xx/"))
assert.deepEqual(fetched, [
"https://gen.nomadkaraoke.com/de/requests/?utm_source=x",
"https://gen.nomadkaraoke.com/ja/requests/",
])
assert.equal(res.status, 302)
})
test("pickLocale honours q-weights, primary subtags and falls back to en", () => {
assert.equal(pickLocale("xx,ja;q=0.5,de;q=0.9"), "de")
assert.equal(pickLocale("pt-BR"), "pt")
assert.equal(pickLocale("nn-NO"), "nb")
assert.equal(pickLocale("fr;q=0"), "en")
assert.equal(pickLocale(""), "en")
assert.equal(pickLocale(null), "en")
})
test("LOCALES mirrors frontend/i18n/routing.ts", () => {
const routing = readFileSync(new URL("../../../frontend/i18n/routing.ts", import.meta.url), "utf8")
const block = routing.slice(routing.indexOf("locales: ["), routing.indexOf("]", routing.indexOf("locales: [")))
assert.deepEqual([...block.matchAll(/'([a-z]{2})'/g)].map((m) => m[1]), LOCALES)
})
test("static assets are proxied from gen", async () => {
await worker.fetch(new Request("https://requests.nomadkaraoke.com/_next/static/chunks/abc.js"))
await worker.fetch(new Request("https://requests.nomadkaraoke.com/en/requests/index.txt?_rsc=1"))
+1 -1
View File
@@ -1,6 +1,6 @@
[tool.poetry]
name = "karaoke-gen"
version = "0.278.17"
version = "0.279.0"
description = "Generate karaoke videos with synchronized lyrics. Handles the entire process from downloading audio and lyrics to creating the final video with title screens."
authors = ["Andrew Beveridge <andrew@beveridge.uk>"]
license = "MIT"