mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
fix: make E2E job card polling resilient to transient DOM changes (#654)
## Summary - E2E happy path test failed because the job card DOM element briefly disappeared during a status transition (step 9/10 "Packaging files"), causing an unhandled `TimeoutError` on `jobCard.textContent()` - Wrapped all `textContent()` calls in polling loops with try/catch and a 15s explicit timeout so transient DOM disappearances retry instead of crashing the test - Applied fix to both `happy-path-real-user.spec.ts` and `demo-recording.spec.ts` Fixes: https://github.com/nomadkaraoke/karaoke-gen/actions/runs/23887007717 ## Test plan - [x] Verified TypeScript has no new errors (all existing errors are pre-existing Playwright type issues) - [ ] Next scheduled E2E run will validate the fix against production @coderabbitai ignore 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
1 parent
fbe3edceec
commit
a0e6448e7b
3 files changed
+37
-6
No files matched your search
@@ -300,7 +300,14 @@ test.describe('Demo Video Recording', () => {
|
||||
break;
|
||||
}
|
||||
|
||||
const statusText = await jobCard.textContent() || '';
|
||||
let statusText: string;
|
||||
try {
|
||||
statusText = await jobCard.textContent({ timeout: 15000 }) || '';
|
||||
} catch {
|
||||
console.log(' Job card temporarily unavailable, retrying...');
|
||||
await page.waitForTimeout(5000);
|
||||
continue;
|
||||
}
|
||||
if (statusText.toLowerCase().includes('failed')) {
|
||||
throw new Error('Job failed during processing');
|
||||
}
|
||||
@@ -456,7 +463,14 @@ test.describe('Demo Video Recording', () => {
|
||||
await page.waitForTimeout(2000);
|
||||
}
|
||||
|
||||
const statusText = await jobCard.textContent() || '';
|
||||
let statusText: string;
|
||||
try {
|
||||
statusText = await jobCard.textContent({ timeout: 15000 }) || '';
|
||||
} catch {
|
||||
console.log(' Job card temporarily unavailable, retrying...');
|
||||
await page.waitForTimeout(5000);
|
||||
continue;
|
||||
}
|
||||
if (statusText.toLowerCase().includes('complete') && !statusText.toLowerCase().includes('prep')) {
|
||||
isComplete = true;
|
||||
break;
|
||||
|
||||
@@ -568,7 +568,15 @@ test.describe('E2E Happy Path - Real User with Full UI Interactions', () => {
|
||||
}
|
||||
|
||||
// Check job card status text
|
||||
const statusText = await jobCard.textContent() || '';
|
||||
// Job card may briefly disappear during re-renders; retry on next poll if so
|
||||
let statusText: string;
|
||||
try {
|
||||
statusText = await jobCard.textContent({ timeout: 15000 }) || '';
|
||||
} catch {
|
||||
console.log(` [${elapsedMin}m ${elapsedSec}s] Job card temporarily unavailable, retrying...`);
|
||||
await page.waitForTimeout(5000);
|
||||
continue;
|
||||
}
|
||||
|
||||
// Check if the "Review Lyrics" link is visible (most reliable indicator)
|
||||
const reviewLink = jobCard.getByRole('link', { name: /review lyrics/i });
|
||||
@@ -831,7 +839,16 @@ test.describe('E2E Happy Path - Real User with Full UI Interactions', () => {
|
||||
await page.waitForTimeout(2000);
|
||||
}
|
||||
|
||||
const statusText = await jobCard.textContent() || '';
|
||||
// Job card may briefly disappear during re-renders (e.g., status transitions).
|
||||
// Catch timeout errors and retry on next poll iteration instead of failing the test.
|
||||
let statusText: string;
|
||||
try {
|
||||
statusText = await jobCard.textContent({ timeout: 15000 }) || '';
|
||||
} catch {
|
||||
console.log(' Job card temporarily unavailable, retrying...');
|
||||
await page.waitForTimeout(5000);
|
||||
continue;
|
||||
}
|
||||
|
||||
if (statusText.toLowerCase().includes('complete') && !statusText.toLowerCase().includes('prep')) {
|
||||
isComplete = true;
|
||||
@@ -949,7 +966,7 @@ test.describe('E2E Happy Path - Real User with Full UI Interactions', () => {
|
||||
console.log('========================================');
|
||||
|
||||
// Private mode skips public distribution (YouTube, GDrive) — only Dropbox may be present
|
||||
const cardText = await jobCard.textContent() || '';
|
||||
const cardText = await jobCard.textContent({ timeout: 15000 }).catch(() => '') || '';
|
||||
|
||||
if (cardText.toLowerCase().includes('youtube') ||
|
||||
cardText.toLowerCase().includes('drive')) {
|
||||
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
[tool.poetry]
|
||||
name = "karaoke-gen"
|
||||
version = "0.157.2"
|
||||
version = "0.157.3"
|
||||
description = "Generate karaoke videos with synchronized lyrics. Handles the entire process from downloading audio and lyrics to creating the final video with title screens."
|
||||
authors = ["Andrew Beveridge <andrew@beveridge.uk>"]
|
||||
license = "MIT"
|
||||
|
||||
Reference in new issue
Block a user