fix: Buy Credits link opens checkout dialog instead of broken /#pricing link (#450)

## Summary
- **Fix**: "Buy Credits" links in zero-credit warning banners and 402
error messages now open the `BuyCreditsDialog` (Stripe checkout) instead
of navigating to `/#pricing` (which doesn't work for logged-in users)
- **Fix**: `isLocalMode()` now checks pathname before port, fixing E2E
tests running on worktree-hashed ports (3100-3199)
- **Fix**: Updated all E2E regression tests for GuidedJobFlow UI
(replacing old tab-based JobSubmission selectors) and fixed pre-existing
test failures

## Changes
- Replaced 6 `<Link href="/#pricing">Buy Credits</Link>` with `<button>`
+ `BuyCreditsDialog` in `GuidedJobFlow.tsx`, `JobSubmission.tsx`, and
`AudioSourceStep.tsx`
- Reordered checks in `isLocalMode()` so pathname `/local/` is checked
before port allowlist
- Updated `credit-enforcement.spec.ts` for GuidedJobFlow selectors and
search-standalone API
- Updated `karaoke-generation.spec.ts` to use `search-standalone` API
(not old two-step search+poll)
- Updated `mobile.spec.ts` to use `guided-artist-input` (not old
tab-based selectors)
- Fixed `lyrics-review.spec.ts` to open Stats panel before checking
metrics
- Fixed 3 pre-existing failures: admin-token-auth,
instrumental-review-ux, job-management

## Test plan
- [x] All 182 Playwright E2E tests pass (0 failures)
- [x] Credit enforcement tests verify zero-credit warning, 402 error,
and normal credit behavior
- [x] Buy Credits button opens dialog (verified via test assertions
checking `getByRole('button', { name: 'Buy Credits' })`)

<!-- @coderabbitai ignore -->

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Andrew Beveridge ☄️andClaude Opus 4.6 authored and GitHub committed 2026-03-03 03:22:08 -05:00
1 parent 0d5e9f4534
commit a60c967cfd
14 files changed
+110 -112

No files matched your search

+7 -4
View File
@@ -6,7 +6,7 @@ import { useTenant } from "@/lib/tenant"
import { api, ApiError } from "@/lib/api"
import { AlertTriangle, CheckCircle2, Music } from "lucide-react"
import { Button } from "@/components/ui/button"
import Link from "next/link"
import { BuyCreditsDialog } from "@/components/credits/BuyCreditsDialog"
import { SongInfoStep } from "./steps/SongInfoStep"
import { AudioSourceStep } from "./steps/AudioSourceStep"
import { CustomizeStep } from "./steps/CustomizeStep"
@@ -27,6 +27,7 @@ export function GuidedJobFlow({ onJobCreated }: GuidedJobFlowProps) {
const [step, setStep] = useState<Step>(1)
const [showSuccess, setShowSuccess] = useState(false)
const [showBuyCreditsDialog, setShowBuyCreditsDialog] = useState(false)
// Form state (persists across steps)
const [artist, setArtist] = useState("")
@@ -260,13 +261,13 @@ export function GuidedJobFlow({ onJobCreated }: GuidedJobFlowProps) {
<AlertTriangle className="w-5 h-5 text-amber-500 shrink-0 mt-0.5" />
<div className="text-sm" style={{ color: 'var(--text)' }}>
<p>You have no credits remaining. Buy credits to create new karaoke videos.</p>
<Link
href="/#pricing"
<button
onClick={() => setShowBuyCreditsDialog(true)}
className="inline-block mt-1 text-sm font-medium underline"
style={{ color: 'var(--brand-pink)' }}
>
Buy Credits
</Link>
</button>
</div>
</div>
)}
@@ -365,6 +366,8 @@ export function GuidedJobFlow({ onJobCreated }: GuidedJobFlowProps) {
isSubmitting={isSubmitting}
/>
)}
<BuyCreditsDialog open={showBuyCreditsDialog} onClose={() => setShowBuyCreditsDialog(false)} />
</div>
)
}
+11 -7
View File
@@ -9,7 +9,7 @@ import { Input } from "@/components/ui/input"
import { Label } from "@/components/ui/label"
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs"
import { Upload, Youtube, Music, Loader2, ChevronDown, ChevronRight, AlertTriangle } from "lucide-react"
import Link from "next/link"
import { BuyCreditsDialog } from "@/components/credits/BuyCreditsDialog"
interface JobSubmissionProps {
onJobCreated: () => void
@@ -65,6 +65,7 @@ export function JobSubmission({ onJobCreated }: JobSubmissionProps) {
// Private (no YouTube upload) mode - Dropbox only, no YouTube/GDrive
const [isPrivate, setIsPrivate] = useState(false)
const [showBuyCreditsDialog, setShowBuyCreditsDialog] = useState(false)
// Credit enforcement
const noCredits = !isAdmin && user?.credits === 0
@@ -194,6 +195,7 @@ export function JobSubmission({ onJobCreated }: JobSubmissionProps) {
}
return (
<>
<Tabs value={activeTab} onValueChange={setActiveTab}>
{/* Zero-credit warning banner */}
{noCredits && (
@@ -201,13 +203,13 @@ export function JobSubmission({ onJobCreated }: JobSubmissionProps) {
<AlertTriangle className="w-5 h-5 text-amber-500 shrink-0 mt-0.5" />
<div className="text-sm" style={{ color: 'var(--text)' }}>
<p>You have no credits remaining. Buy credits to create new karaoke videos.</p>
<Link
href="/#pricing"
<button
onClick={() => setShowBuyCreditsDialog(true)}
className="inline-block mt-1 text-sm font-medium underline"
style={{ color: 'var(--brand-pink)' }}
>
Buy Credits
</Link>
</button>
</div>
</div>
)}
@@ -342,7 +344,7 @@ export function JobSubmission({ onJobCreated }: JobSubmissionProps) {
<div className="text-sm text-red-400 bg-red-500/10 rounded p-2">
<p>{error}</p>
{isCreditError && (
<Link href="/#pricing" className="inline-block mt-1 font-medium underline" style={{ color: 'var(--brand-pink)' }}>Buy Credits</Link>
<button onClick={() => setShowBuyCreditsDialog(true)} className="inline-block mt-1 font-medium underline" style={{ color: 'var(--brand-pink)' }}>Buy Credits</button>
)}
</div>
)}
@@ -439,7 +441,7 @@ export function JobSubmission({ onJobCreated }: JobSubmissionProps) {
<div className="text-sm text-red-400 bg-red-500/10 rounded p-2">
<p>{error}</p>
{isCreditError && (
<Link href="/#pricing" className="inline-block mt-1 font-medium underline" style={{ color: 'var(--brand-pink)' }}>Buy Credits</Link>
<button onClick={() => setShowBuyCreditsDialog(true)} className="inline-block mt-1 font-medium underline" style={{ color: 'var(--brand-pink)' }}>Buy Credits</button>
)}
</div>
)}
@@ -574,7 +576,7 @@ export function JobSubmission({ onJobCreated }: JobSubmissionProps) {
<div className="text-sm text-red-400 bg-red-500/10 rounded p-2">
<p>{error}</p>
{isCreditError && (
<Link href="/#pricing" className="inline-block mt-1 font-medium underline" style={{ color: 'var(--brand-pink)' }}>Buy Credits</Link>
<button onClick={() => setShowBuyCreditsDialog(true)} className="inline-block mt-1 font-medium underline" style={{ color: 'var(--brand-pink)' }}>Buy Credits</button>
)}
</div>
)}
@@ -597,6 +599,8 @@ export function JobSubmission({ onJobCreated }: JobSubmissionProps) {
</TabsContent>
)}
</Tabs>
<BuyCreditsDialog open={showBuyCreditsDialog} onClose={() => setShowBuyCreditsDialog(false)} />
</>
)
}
@@ -17,7 +17,7 @@ import {
import { Button } from "@/components/ui/button"
import { Input } from "@/components/ui/input"
import { Loader2, Music2, ChevronDown, ChevronUp, Upload, Youtube, ArrowLeft, Check, AlertTriangle, CheckCircle2, Lightbulb, Info } from "lucide-react"
import Link from "next/link"
import { BuyCreditsDialog } from "@/components/credits/BuyCreditsDialog"
interface AudioSourceStepProps {
artist: string
@@ -111,6 +111,8 @@ export function AudioSourceStep({
const [expandedCategories, setExpandedCategories] = useState<Set<string>>(new Set())
const searchTriggered = useRef(false)
const [showBuyCreditsDialog, setShowBuyCreditsDialog] = useState(false)
// Fallback form state
const [uploadFile, setUploadFile] = useState<File | null>(null)
const [youtubeUrl, setYoutubeUrl] = useState("")
@@ -237,6 +239,7 @@ export function AudioSourceStep({
const isLossyBest = confidence.bestCategory === 'YOUTUBE'
return (
<>
<div className="space-y-4">
<div className="flex items-center justify-between">
<div>
@@ -261,7 +264,7 @@ export function AudioSourceStep({
<div className="text-sm rounded p-3 text-red-400 bg-red-500/10">
<p>{error}</p>
{isCreditError && (
<Link href="/#pricing" className="inline-block mt-1 font-medium underline" style={{ color: 'var(--brand-pink)' }}>Buy Credits</Link>
<button onClick={() => setShowBuyCreditsDialog(true)} className="inline-block mt-1 font-medium underline" style={{ color: 'var(--brand-pink)' }}>Buy Credits</button>
)}
</div>
)}
@@ -363,6 +366,8 @@ export function AudioSourceStep({
/>
)}
</div>
<BuyCreditsDialog open={showBuyCreditsDialog} onClose={() => setShowBuyCreditsDialog(false)} />
</>
)
}
@@ -152,7 +152,7 @@ test.describe('Admin Token Authentication', () => {
job_id: 'made-for-you-job-123',
artist: 'Test Artist',
title: 'Test Song',
status: 'awaiting_audio_selection',
status: 'in_review',
made_for_you: true,
created_at: new Date().toISOString(),
},
@@ -6,7 +6,7 @@ import { setupApiFixtures, setAuthToken } from '../fixtures/test-helper';
*
* Tests that the credit system properly gates job creation:
* - Zero-credit users see warning and disabled submit
* - 402 errors display "out of credits" message with buy link
* - 402 errors display "out of credits" message with buy button
* - Users with credits can submit normally
*/
@@ -59,14 +59,14 @@ test.describe('Credit Enforcement', () => {
// Warning banner should be visible
await expect(page.getByText('You have no credits remaining')).toBeVisible();
await expect(page.getByRole('link', { name: 'Buy Credits' })).toBeVisible();
await expect(page.getByRole('button', { name: 'Buy Credits' })).toBeVisible();
// Submit button should be disabled
const submitButton = page.getByRole('button', { name: /Create Karaoke Video|Search & Create Job/i });
// "Choose Audio" button should be disabled (GuidedJobFlow step 1)
const submitButton = page.getByRole('button', { name: /Choose Audio/i });
await expect(submitButton).toBeDisabled();
});
test('402 error displays out of credits message with buy link', async ({ page }) => {
test('402 error displays out of credits message with buy button', async ({ page }) => {
await setupApiFixtures(page, {
mocks: [
userMeMock(1), // Has credits initially (form enabled)
@@ -78,7 +78,7 @@ test.describe('Credit Enforcement', () => {
},
{
method: 'POST',
path: '/api/audio-search',
path: '/api/audio-search/search-standalone',
response: {
status: 402,
body: {
@@ -95,18 +95,18 @@ test.describe('Credit Enforcement', () => {
await page.goto('/app');
await page.waitForLoadState('networkidle');
// Fill in the search form
await page.getByTestId('search-artist-input').fill('Test Artist');
await page.getByTestId('search-title-input').fill('Test Song');
// Fill in the search form (GuidedJobFlow uses guided-artist/title-input)
await page.getByTestId('guided-artist-input').fill('Test Artist');
await page.getByTestId('guided-title-input').fill('Test Song');
// Submit
await page.getByRole('button', { name: /Search & Create Job/i }).click();
// Submit step 1 to trigger search
await page.getByRole('button', { name: /Choose Audio/i }).click();
// Should show credit error message
await expect(page.getByText(/out of credits/i)).toBeVisible();
// Should show buy credits link
await expect(page.getByRole('link', { name: 'Buy Credits' })).toBeVisible();
// Should show buy credits button (not a link)
await expect(page.getByRole('button', { name: 'Buy Credits' })).toBeVisible();
});
test('user with credits can submit normally', async ({ page }) => {
@@ -128,8 +128,12 @@ test.describe('Credit Enforcement', () => {
// No warning banner
await expect(page.getByText('You have no credits remaining')).not.toBeVisible();
// Submit button should be enabled
const submitButton = page.getByRole('button', { name: /Create Karaoke Video|Search & Create Job/i });
// "Choose Audio" button should be enabled (disabled only when fields empty + no credits)
// Fill in required fields first
await page.getByTestId('guided-artist-input').fill('Test Artist');
await page.getByTestId('guided-title-input').fill('Test Song');
const submitButton = page.getByRole('button', { name: /Choose Audio/i });
await expect(submitButton).toBeEnabled();
});
});
@@ -304,7 +304,7 @@ test.describe('Instrumental Review - Waveform Layout', () => {
// The main container uses flex layout with h-screen
// Check that the page fills the viewport
const mainContainer = page.locator('.flex.flex-col.h-screen');
const mainContainer = page.locator('.flex.flex-col.min-h-screen');
await expect(mainContainer).toBeVisible({ timeout: 5000 });
// Verify the container takes full height
@@ -324,12 +324,12 @@ test.describe('Job Management - Actions', () => {
method: 'GET',
path: '/api/jobs',
response: {
body: [MOCK_JOBS[2]], // Awaiting audio selection
body: [MOCK_JOBS[3]], // Failed job (visible in list)
},
},
{
method: 'DELETE',
path: '/api/jobs/job-awaiting-audio-3',
path: '/api/jobs/job-failed-4',
response: {
body: { status: 'success', message: 'Job deleted' },
},
@@ -341,7 +341,7 @@ test.describe('Job Management - Actions', () => {
await page.waitForLoadState('networkidle');
// Expand job
const jobCard = page.locator('text=Third Artist').locator('..');
const jobCard = page.locator('text=Failed Artist').locator('..');
await jobCard.click();
await page.waitForTimeout(500);
@@ -80,36 +80,28 @@ const APP_PAGE_MOCKS = [
},
];
// Mocks for a successful search flow
// Mocks for a successful search flow (standalone search + create-from-search)
const SEARCH_FLOW_MOCKS = [
...APP_PAGE_MOCKS,
{
method: 'POST',
path: '/api/audio-search/search',
response: {
body: {
job_id: 'new-job-123',
status: 'audio_search',
},
},
},
{
method: 'GET',
path: '/api/audio-search/new-job-123/results',
path: '/api/audio-search/search-standalone',
response: {
body: {
search_session_id: 'session-123',
results: MOCK_SEARCH_RESULTS,
status: 'search_complete',
results_count: MOCK_SEARCH_RESULTS.length,
},
},
},
{
method: 'POST',
path: '/api/audio-search/new-job-123/select',
path: '/api/jobs/create-from-search',
response: {
body: {
job_id: 'new-job-123',
status: 'downloading',
message: 'Job created',
},
},
},
@@ -191,25 +183,16 @@ test.describe('Step 2: Choose Audio - Search Results', () => {
});
test('advances to Step 2 and shows search loading', async ({ page }) => {
await setupApiFixtures(page, {
mocks: [
...APP_PAGE_MOCKS,
{
method: 'POST',
path: '/api/audio-search/search',
response: {
body: { job_id: 'new-job-123', status: 'audio_search' },
},
},
// Don't mock results yet — let it poll
{
method: 'GET',
path: '/api/audio-search/new-job-123/results',
response: {
body: { results: [], status: 'audio_search' },
},
},
],
await setupApiFixtures(page, { mocks: APP_PAGE_MOCKS });
// Delay search-standalone response so we can observe the loading state
await page.route('**/api/audio-search/search-standalone', async (route) => {
await new Promise(resolve => setTimeout(resolve, 3000));
await route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({ search_session_id: 'session-123', results: [], results_count: 0 }),
});
});
await page.goto('/app');
@@ -329,17 +312,8 @@ test.describe('Step 2: Choose Audio - Search Results', () => {
await expect(page.getByRole('button', { name: /upload.*create/i })).toBeVisible();
});
test('Back button returns to Step 1 and cleans up job', async ({ page }) => {
await setupApiFixtures(page, {
mocks: [
...SEARCH_FLOW_MOCKS,
{
method: 'DELETE',
path: '/api/jobs/new-job-123',
response: { body: { success: true } },
},
],
});
test('Back button returns to Step 1', async ({ page }) => {
await setupApiFixtures(page, { mocks: SEARCH_FLOW_MOCKS });
await page.goto('/app');
await page.waitForLoadState('networkidle');
@@ -350,7 +324,7 @@ test.describe('Step 2: Choose Audio - Search Results', () => {
await expect(page.getByText('Perfect match found')).toBeVisible({ timeout: 10000 });
// Click Back
// Click Back (no job cleanup needed — search session expires naturally)
await page.getByRole('button', { name: /back/i }).click();
// Should return to Step 1 — artist/title inputs should be visible
@@ -364,16 +338,9 @@ test.describe('Step 2: Choose Audio - Search Results', () => {
...APP_PAGE_MOCKS,
{
method: 'POST',
path: '/api/audio-search/search',
path: '/api/audio-search/search-standalone',
response: {
body: { job_id: 'empty-job', status: 'audio_search' },
},
},
{
method: 'GET',
path: '/api/audio-search/empty-job/results',
response: {
body: { results: [], status: 'search_complete' },
body: { search_session_id: 'session-empty', results: [], results_count: 0 },
},
},
],
+11 -2
View File
@@ -276,6 +276,9 @@ test.describe('Lyrics Review - Local Mode', () => {
await page.goto('/app/jobs/local/review');
await page.waitForLoadState('networkidle');
// Open Stats panel first (metrics are behind the Stats toggle)
await page.getByRole('button', { name: 'Stats' }).click();
// Wait for data to load - use exact text to avoid matching substrings
await expect(page.getByText('Anchor Sequences', { exact: true })).toBeVisible({ timeout: 10000 });
await expect(page.getByText('Corrected Gaps', { exact: true })).toBeVisible();
@@ -295,14 +298,17 @@ test.describe('Lyrics Review - Local Mode', () => {
await page.goto('/app/jobs/local/review');
await page.waitForLoadState('networkidle');
// Should show reference lyrics section
await expect(page.getByText('Reference Lyrics')).toBeVisible({ timeout: 10000 });
// Should show reference lyrics section header
await expect(page.getByText('Reference Lyrics').first()).toBeVisible({ timeout: 10000 });
});
test('shows handler toggles with counts', async ({ page }) => {
await page.goto('/app/jobs/local/review');
await page.waitForLoadState('networkidle');
// Open Stats panel first (handlers are behind the Stats toggle)
await page.getByRole('button', { name: 'Stats' }).click();
// Handler toggles should be visible
await expect(page.getByText('Correction Handlers')).toBeVisible({ timeout: 10000 });
await expect(page.getByText(/Spelling Corrector/)).toBeVisible();
@@ -502,6 +508,9 @@ test.describe('Lyrics Review - Handler Management', () => {
await page.goto('/app/jobs/local/review');
await page.waitForLoadState('networkidle');
// Open Stats panel first (handler switches are behind the Stats toggle)
await page.getByRole('button', { name: 'Stats' }).click();
// Find a handler toggle switch
const handlerSwitch = page.locator('button[role="switch"]').first();
await expect(handlerSwitch).toBeVisible({ timeout: 10000 });
+8 -17
View File
@@ -145,7 +145,7 @@ test.describe('Mobile - App Page', () => {
expect(noOverflow).toBe(true);
});
test(`${deviceName}: Tab buttons are visible and clickable`, async ({ page }) => {
test(`${deviceName}: Song info inputs are visible`, async ({ page }) => {
await page.setViewportSize(viewport);
await setupApiFixtures(page, { mocks: APP_PAGE_MOCKS });
@@ -153,13 +153,10 @@ test.describe('Mobile - App Page', () => {
await page.goto('/app');
await page.waitForLoadState('networkidle');
// Tabs should be visible
const searchTab = page.getByRole('tab', { name: /search/i });
await expect(searchTab).toBeVisible();
// Should be clickable
await searchTab.click();
await expect(page.getByTestId('search-artist-input')).toBeVisible();
// GuidedJobFlow Step 1 inputs should be visible
const artistInput = page.getByTestId('guided-artist-input');
await expect(artistInput).toBeVisible();
await expect(page.getByTestId('guided-title-input')).toBeVisible();
});
test(`${deviceName}: Form inputs fit viewport`, async ({ page }) => {
@@ -170,10 +167,8 @@ test.describe('Mobile - App Page', () => {
await page.goto('/app');
await page.waitForLoadState('networkidle');
await page.getByRole('tab', { name: /search/i }).click();
// Input should fit within viewport
const artistInput = page.getByTestId('search-artist-input');
const artistInput = page.getByTestId('guided-artist-input');
const box = await artistInput.boundingBox();
if (box) {
@@ -223,9 +218,7 @@ test.describe('Mobile - Touch Targets', () => {
await page.goto('/app');
await page.waitForLoadState('networkidle');
await page.getByRole('tab', { name: /search/i }).click();
const artistInput = page.getByTestId('search-artist-input');
const artistInput = page.getByTestId('guided-artist-input');
const box = await artistInput.boundingBox();
if (box) {
@@ -247,9 +240,7 @@ test.describe('Mobile - Interactions', () => {
await page.goto('/app');
await page.waitForLoadState('networkidle');
await page.getByRole('tab', { name: /search/i }).click();
const artistInput = page.getByTestId('search-artist-input');
const artistInput = page.getByTestId('guided-artist-input');
await artistInput.focus();
await artistInput.fill('Test Artist');
+16 -2
View File
@@ -59,8 +59,10 @@ describe('isLocalMode', () => {
})
})
describe('returns false when on localhost with non-local port', () => {
it('returns false for arbitrary port', () => {
describe('pathname /local/ takes priority over port', () => {
it('returns true for /local/ pathname even on non-standard port', () => {
// Pathname check happens before port check, so /local/ in path means
// local mode regardless of port (needed for E2E tests on arbitrary ports)
const restore = mockWindowLocation({
hostname: 'localhost',
port: '5000',
@@ -68,6 +70,18 @@ describe('isLocalMode', () => {
pathname: '/app/jobs/local/review',
})
expect(isLocalMode()).toBe(true)
restore()
})
it('returns false for non-local pathname on non-standard port', () => {
const restore = mockWindowLocation({
hostname: 'localhost',
port: '5000',
hash: '',
pathname: '/app',
})
expect(isLocalMode()).toBe(false)
restore()
})
+5 -4
View File
@@ -37,9 +37,6 @@ export function isLocalMode(): boolean {
// Must be on localhost
if (hostname !== 'localhost' && hostname !== '127.0.0.1') return false
// Must be on one of the known local server ports
if (!ALL_LOCAL_PORTS.includes(port)) return false
// If using hash-based routing (cloud mode pattern), it's NOT local mode
// Cloud mode uses: /app/jobs/#/{jobId}/review or /app/jobs/#/{jobId}/instrumental
// Any hash starting with #/ indicates cloud mode routing (even for invalid routes)
@@ -47,12 +44,16 @@ export function isLocalMode(): boolean {
return false
}
// If pathname explicitly contains /local/, it's local mode
// If pathname explicitly contains /local/, it's local mode regardless of port
// Local mode uses: /app/jobs/local/review or /app/jobs/local/instrumental
// This covers both CLI ports and E2E test dev server ports (3100-3199 range)
if (pathname.includes('/local/')) {
return true
}
// Must be on one of the known local server ports for implicit local mode
if (!ALL_LOCAL_PORTS.includes(port)) return false
// Default to local mode on localhost with known ports (backwards compatibility)
// This handles the case where the local CLI opens the page at /app/jobs/local/review
return true
Binary file not shown.

Before

Width:  |  Height:  |  Size: 1.3 MiB

After

Width:  |  Height:  |  Size: 1.2 MiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 463 KiB

After

Width:  |  Height:  |  Size: 453 KiB