mirror of
https://github.com/nomadkaraoke/karaoke-gen.git
synced 2026-11-20 13:07:57 +09:00
## Summary On 2026-11-04 at 10:00Z a PR opened on python-audio-separator queued a burst of `workflow_job` webhooks. 22 of 54 deliveries got a 500 from Cloud Run while `github-runner-manager` scaled up. The error monitor alerted because Cloud Run used a second wording, "aborted after waiting too long for an available instance", which the existing ignore pattern didn't match. There was no impact: all self-hosted jobs in the affected runs got runners within about 3.5 minutes and passed. ## Changes - **Error monitor:** match both Cloud Run abort wordings for `github-runner-manager`, but only on **webhook** requests (the bare function URL). Cloud Scheduler ticks (`?action=check_idle`) and entries with no URL still alert. `_SERVICE_URL_IGNORE_PATTERNS` now accepts a predicate on the split URL as well as an exact path. - **Runner manager (Cloud Function):** the ignore relies on the 5-minute stalled-job tick catching dropped webhooks, so that tick's own failures now log as structured `severity: ERROR` and page. That covers a redispatch crash, a repo skipped in the scan, a job given up at 60 min, and a failed re-dispatch. Before this, they were severity-less prints that nothing alerted on. Both changes came from CodeRabbit feedback. - Corrected the pattern's reason: GitHub did not redeliver these (`redelivery: false`). - Version 0.292.1; merged latest main. ## ⚠️ Deploy `infrastructure/functions/runner_manager/` only goes live with a local `pulumi up` (CI never runs Pulumi). Apply it **before** merging, so the safety net's alerting is live before the webhook-abort ignore ships with the backend deploy. ## Testing - `tests/unit/services/error_monitor/`: 452 passed (webhook, scheduler-tick, no-URL and other-service cases for both wordings). - `infrastructure/functions/runner_manager`: 71 passed. The 4 updated tests fail against main's `ephemeral.py`. - Full `make test` not run locally; relying on CI. Alert: https://discord.com/channels/1198691101943541770/1265517528608669707/1567479055887114363 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_012RYLVVTKcWCcDArTQrjS82 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **Bug Fixes** * Runner-manager webhook errors are filtered more precisely. Recognized abort messages are ignored only for matching webhook requests; scheduler-tick errors, requests with other URLs, and requests without a URL continue to trigger alerts. * Runner-manager job-processing failures are recorded as structured error logs, including stalled-job scans and dispatch failures. Give-up logs now report the configured limit rather than the job’s current time in the queue. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Backend Development Setup
One-Time Setup
1. Create Virtual Environment
cd /Users/andrew/Projects/karaoke-gen
python3 -m venv backend/venv
2. Activate Virtual Environment
source backend/venv/bin/activate
3. Install Dependencies
IMPORTANT: Use Python 3.12 (not 3.13/3.14 - pydantic has compatibility issues)
# Backend dependencies
pip install -r backend/requirements.txt
# Install karaoke_gen in development mode
pip install -e .
# Install lyrics_transcriber submodule
pip install -e lyrics_transcriber_local/
# Install Google API client (for YouTube upload)
pip install google-api-python-client google-auth-httplib2 google-auth-oauthlib
4. Add Shell Alias (Optional)
Add to ~/.zshrc:
alias backend='cd /Users/andrew/Projects/karaoke-gen && source backend/venv/bin/activate'
Then you can just run:
backend
# Now you're in the project directory with venv activated!
Daily Workflow
Before Making Changes
# Activate venv
source backend/venv/bin/activate
# Or if you set up the alias:
backend
After Making Changes
# 1. Run full validation (catches import errors!)
python3 backend/validate.py
# 2. If validation passes, deploy
./scripts/deploy.sh
Validation Options
Full Validation (Recommended - Requires venv)
source backend/venv/bin/activate
python3 backend/validate.py
Catches:
- ✅ Syntax errors
- ✅ Import errors (like the processing_service issue!)
- ✅ Configuration issues
- ✅ FastAPI app creation problems
- ✅ Missing dependencies
This would have caught the ModuleNotFoundError!
Quick Check (No venv needed)
./backend/quick-check.sh
Catches:
- ✅ Syntax errors
- ✅ Missing files
- ✅ Some obvious import issues
Good for quick checks, but won't catch all import errors
Example: Complete Development Session
# 1. Activate environment
backend # or: source backend/venv/bin/activate
# 2. Make your changes
vim backend/api/routes/jobs.py
# 3. Validate (catches import errors!)
python3 backend/validate.py
# ✅ All validations passed!
# 4. Deploy
./scripts/deploy.sh
# 5. Test
export BACKEND_URL="https://karaoke-backend-ipzqd2k4yq-uc.a.run.app"
export AUTH_TOKEN=$(gcloud auth print-identity-token)
curl -H "Authorization: Bearer $AUTH_TOKEN" $BACKEND_URL/api/health
What About karaoke_gen Imports?
The backend imports from karaoke_gen (the CLI package):
from karaoke_gen.karaoke_gen import KaraokePrep
from karaoke_gen.audio_processor import AudioProcessor
Options:
Option 1: Install in development mode (Recommended)
source backend/venv/bin/activate
pip install -e .
This makes karaoke_gen available in the venv without copying files.
Option 2: Use system Python
Your system Python already has karaoke_gen installed, so validation will work even if the venv doesn't have it (Python will fall back to system packages).
Running the Backend Locally
# Activate venv
source backend/venv/bin/activate
# Set required environment variables
export GOOGLE_CLOUD_PROJECT="nomadkaraoke"
export GCS_BUCKET_NAME="karaoke-gen-storage-nomadkaraoke"
# Optional: Point to local credentials
export GOOGLE_APPLICATION_CREDENTIALS="/path/to/service-account-key.json"
# Run the server
cd backend
uvicorn main:app --reload --port 8080
Visit: http://localhost:8080/api/health
Troubleshooting
"No module named 'fastapi'"
Fix:
source backend/venv/bin/activate
pip install -r backend/requirements.txt
"No module named 'karaoke_gen'"
Fix:
source backend/venv/bin/activate
cd /Users/andrew/Projects/karaoke-gen
pip install -e .
Validation passes locally but fails in Cloud Run
Check:
- Is
requirements.txtup to date? - Did you add a new dependency without adding it to
requirements.txt? - Run:
pip freeze | grep <package-name>
Updating Dependencies
When you add new packages:
# 1. Install in venv
source backend/venv/bin/activate
pip install new-package
# 2. Update requirements.txt
pip freeze > backend/requirements.txt
# 3. Or manually add just the new package:
echo "new-package==1.2.3" >> backend/requirements.txt
# 4. Validate
python3 backend/validate.py
# 5. Deploy
./scripts/deploy.sh
Summary
Best practice workflow:
- One-time setup: Create venv and install dependencies
- Daily: Activate venv when working on backend
- Before deploy: Run
python3 backend/validate.py(catches import errors!) - Deploy: Use
./scripts/deploy.sh
The import error would have been caught if you ran validation in a venv! ✅