feat(iam): claude-readonly may read all secret values (Andrew's call)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012RYLVVVVLQSWvtZqBGxRFb
This commit is contained in:
Andrew BeveridgeandClaude Opus 5.5 committed 2026-11-19 13:31:47 -05:00
1 parent 73a72daccd
commit f50efed4ef
2 files changed
+6 -14

No files matched your search

+1 -1
View File
@@ -68,7 +68,7 @@ This single command:
When asked to "test it yourself in prod" or verify a fix in production:
```bash
# Get admin token. claude-readonly@ may read this one secret (Pulumi:
# Get admin token. claude-readonly@ can read all secrets (Pulumi:
# infrastructure/modules/iam/claude_readonly_sa.py), so no gcloud login is needed.
export KARAOKE_ADMIN_TOKEN=$(gcloud secrets versions access latest --secret=admin-tokens --project=nomadkaraoke --account=claude-readonly@nomadkaraoke.iam.gserviceaccount.com | cut -d',' -f1)
@@ -44,6 +44,11 @@ def grant_claude_readonly_permissions(
"bigquery_job_user": "roles/bigquery.jobUser",
"storage_viewer": "roles/storage.objectViewer",
"secretmanager_viewer": "roles/secretmanager.viewer",
# Secret VALUES too (Andrew, 2026-11-19): sessions need the admin API
# token, OAuth creds etc. for remediation, and the gcloud CLI user login
# keeps lapsing. This makes the SA's key secret-equivalent: anyone with
# it can read every secret in the project.
"secretmanager_accessor": "roles/secretmanager.secretAccessor",
"run_viewer": "roles/run.viewer",
"compute_viewer": "roles/compute.viewer",
"logging_viewer": "roles/logging.viewer",
@@ -59,19 +64,6 @@ def grant_claude_readonly_permissions(
),
)
# The one secret sessions may read: the backend admin API token. Sessions
# need it to retry/inspect jobs via the API (CLAUDE.md "API Authentication"),
# and the gcloud CLI's user login lapses, so without this every session hit
# a wall. Andrew asked for it on 2026-11-19. Deliberately scoped to this one
# secret; all other secret values stay unreadable to claude-readonly.
bindings["admin_tokens_accessor"] = gcp.secretmanager.SecretIamMember(
"claude-readonly-admin-tokens-access",
project=PROJECT_ID,
secret_id="admin-tokens",
role="roles/secretmanager.secretAccessor",
member=service_account.email.apply(lambda email: f"serviceAccount:{email}"),
)
return bindings