Updates.
This commit is contained in:
1 parent
27678b0e64
commit
2c63ae5420
6 files changed
+140
-1
No files matched your search
@@ -1926,3 +1926,17 @@ This pre-hides all spans so the backward fill takes effect without the one-frame
|
||||
|
||||
**Result:**
|
||||
- Stroke and shadow controls now affect Video mode text consistently, matching user expectations from other preview modes.
|
||||
|
||||
---
|
||||
|
||||
### 2026-03-27 — Add stem delete (trashcan) button to project detail
|
||||
|
||||
Added end-to-end stem deletion:
|
||||
|
||||
- **`backend/services/project_assets_service.py`**: new `delete_project_stem(project, stem_name)` — removes the file from disk (if present) and pops the entry from the separation job's file list in the DB.
|
||||
- **`backend/services/project_service.py`**: re-exported `delete_project_stem` through the compatibility facade.
|
||||
- **`backend/routers/projects.py`**: new `DELETE /api/projects/{project_id}/stem` endpoint with `DeleteStemRequest` body `{ stem_name }`.
|
||||
- **`frontend/src/api/client.ts`**: new `deleteStem(projectId, stemName)` API helper.
|
||||
- **`frontend/src/pages/ProjectDetail.tsx`**: new `StemDeleteButton` component — shows trashcan icon, prompts inline confirmation (checkmark / X) before calling the API. Added to each stem row in `StemsSection` alongside the existing rename and reprocess buttons.
|
||||
|
||||
Also updated SUMMARIES path in memory from `SUMMARIES.md` → `SUMMARIES (Claude).md`.
|
||||
@@ -15,6 +15,7 @@ from ..config import DEFAULT_TRANSCRIBE_MODE
|
||||
from ..services.project_service import (
|
||||
cleanup_all_lrc_output_files,
|
||||
cleanup_rename_all_project_stems,
|
||||
delete_project_stem,
|
||||
enqueue_project_abc_conversion,
|
||||
enqueue_project_lyric_transcription,
|
||||
enqueue_project_lrc_alignment,
|
||||
@@ -300,6 +301,24 @@ def rename_stem_endpoint(project_id: str, body: RenameStemRequest):
|
||||
raise HTTPException(status_code=exc.status_code, detail=exc.detail) from exc
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Stem Delete
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
class DeleteStemRequest(BaseModel):
|
||||
stem_name: str
|
||||
|
||||
|
||||
@router.delete("/{project_id}/stem")
|
||||
def delete_stem_endpoint(project_id: str, body: DeleteStemRequest):
|
||||
"""Delete a stem file from disk and remove it from the job record."""
|
||||
project = _get_project_or_404(project_id)
|
||||
try:
|
||||
return delete_project_stem(project, body.stem_name)
|
||||
except ProjectOperationError as exc:
|
||||
raise HTTPException(status_code=exc.status_code, detail=exc.detail) from exc
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Stem Rescan
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
@@ -190,6 +190,37 @@ def rename_project_stem(project: dict, stem_name: str, new_name: str) -> dict:
|
||||
}
|
||||
|
||||
|
||||
def delete_project_stem(project: dict, stem_name: str) -> dict:
|
||||
"""Delete a tracked stem file from disk and remove it from the separation job record."""
|
||||
sep_job = jobs_repo.get(project["sep_job_id"])
|
||||
if sep_job is None:
|
||||
raise ProjectOperationError(404, "Separation job not found")
|
||||
|
||||
stem_files = list(sep_job.get("files", []))
|
||||
stem_file = None
|
||||
stem_idx = None
|
||||
for index, file_entry in enumerate(stem_files):
|
||||
if file_entry.get("stem") == stem_name or file_entry.get("name") == stem_name:
|
||||
stem_file = file_entry
|
||||
stem_idx = index
|
||||
break
|
||||
|
||||
if stem_file is None or stem_idx is None:
|
||||
raise ProjectOperationError(404, f"Stem not found: {stem_name}")
|
||||
|
||||
stem_path = Path(stem_file["path"])
|
||||
if stem_path.exists():
|
||||
try:
|
||||
stem_path.unlink()
|
||||
except Exception as exc:
|
||||
raise ProjectOperationError(500, f"Failed to delete stem file: {exc}") from exc
|
||||
|
||||
stem_files.pop(stem_idx)
|
||||
jobs_repo.update(project["sep_job_id"], files=stem_files)
|
||||
|
||||
return {"success": True, "deleted": stem_name}
|
||||
|
||||
|
||||
def rescan_project_stems(project: dict, audio_exts: set[str]) -> dict:
|
||||
"""Register untracked audio files under the project's Stems directory."""
|
||||
sep_job = jobs_repo.get(project["sep_job_id"])
|
||||
|
||||
@@ -7,6 +7,7 @@ from .. import job_manager as jm # noqa: F401
|
||||
from .project_assets_service import (
|
||||
build_project_detail,
|
||||
collect_related_job_ids,
|
||||
delete_project_stem,
|
||||
delete_project_with_related_jobs,
|
||||
get_project_cover_art,
|
||||
get_project_or_raise,
|
||||
|
||||
@@ -653,6 +653,15 @@ export const renameStem = (
|
||||
}),
|
||||
})
|
||||
|
||||
// ---------- Stem Delete ----------
|
||||
|
||||
export const deleteStem = (projectId: string, stemName: string) =>
|
||||
request<{ success: boolean; deleted: string }>(`${BASE}/projects/${projectId}/stem`, {
|
||||
method: 'DELETE',
|
||||
headers: { 'Content-Type': 'application/json' },
|
||||
body: JSON.stringify({ stem_name: stemName }),
|
||||
})
|
||||
|
||||
// ---------- Per-Instrument Models ----------
|
||||
|
||||
export const getPerInstrumentModels = () =>
|
||||
|
||||
@@ -7,7 +7,7 @@ import {
|
||||
ListMusic, Edit2, Check, X as XIcon, Wand2, RotateCcw, Copy, Users,
|
||||
Play, Pause, Square, Eye, EyeOff,
|
||||
} from 'lucide-react'
|
||||
import { getProjectDetail, transcribeProject, abcProject, mixProject, lrcProject, lyricTranscribeProject, downloadUrl, reprocessStem, renameStem, getPerInstrumentModels, getTranscribeModes, getLyricModels, projectCoverArtUrl } from '../api/client'
|
||||
import { getProjectDetail, transcribeProject, abcProject, mixProject, lrcProject, lyricTranscribeProject, downloadUrl, reprocessStem, renameStem, deleteStem, getPerInstrumentModels, getTranscribeModes, getLyricModels, projectCoverArtUrl } from '../api/client'
|
||||
import type { ProjectDetail as PD, Job, JobFile, ModeOption, LyricModelsPayload } from '../types'
|
||||
import DynamicMixPlayer from '../components/DynamicMixPlayer'
|
||||
import LyricsLivePreview from '../components/LyricsLivePreview'
|
||||
@@ -893,6 +893,66 @@ function StemRenameButton({
|
||||
)
|
||||
}
|
||||
|
||||
// ─── Stem delete component ──────────────────────────────────────────────────
|
||||
|
||||
function StemDeleteButton({
|
||||
projectId,
|
||||
stemName,
|
||||
onDelete,
|
||||
}: {
|
||||
projectId: string
|
||||
stemName: string
|
||||
onDelete: () => void
|
||||
}) {
|
||||
const [confirming, setConfirming] = useState(false)
|
||||
const [busy, setBusy] = useState(false)
|
||||
|
||||
async function handleDelete() {
|
||||
setBusy(true)
|
||||
try {
|
||||
await deleteStem(projectId, stemName)
|
||||
onDelete()
|
||||
} catch (e) {
|
||||
console.error('Delete failed:', e)
|
||||
} finally {
|
||||
setBusy(false)
|
||||
setConfirming(false)
|
||||
}
|
||||
}
|
||||
|
||||
if (confirming) {
|
||||
return (
|
||||
<div className="flex items-center gap-1">
|
||||
<button
|
||||
onClick={handleDelete}
|
||||
disabled={busy}
|
||||
className="p-0.5 rounded text-red-500 hover:text-red-600"
|
||||
title="Confirm delete"
|
||||
>
|
||||
{busy ? <Loader2 className="w-3 h-3 animate-spin" /> : <Check className="w-3 h-3" />}
|
||||
</button>
|
||||
<button
|
||||
onClick={() => setConfirming(false)}
|
||||
className="p-0.5 rounded ui-text-muted hover:opacity-80"
|
||||
title="Cancel"
|
||||
>
|
||||
<XIcon className="w-3 h-3" />
|
||||
</button>
|
||||
</div>
|
||||
)
|
||||
}
|
||||
|
||||
return (
|
||||
<button
|
||||
onClick={() => setConfirming(true)}
|
||||
className="p-1 rounded ui-text-muted hover:text-red-500 transition-colors"
|
||||
title="Delete stem"
|
||||
>
|
||||
<Trash2 className="w-3 h-3" />
|
||||
</button>
|
||||
)
|
||||
}
|
||||
|
||||
// ─── Stems section ──────────────────────────────────────────────────────────
|
||||
|
||||
function StemsSection({
|
||||
@@ -1108,6 +1168,11 @@ function StemsSection({
|
||||
stemName={f.stem ?? f.name}
|
||||
onReprocess={onAction}
|
||||
/>
|
||||
<StemDeleteButton
|
||||
projectId={project.id}
|
||||
stemName={f.stem ?? f.name}
|
||||
onDelete={onAction}
|
||||
/>
|
||||
</div>
|
||||
))}
|
||||
</div>
|
||||
|
||||
Reference in new issue
Block a user